Skip to content

feat: redirect root path to /portal#298

Closed
stabem wants to merge 1 commit intomainfrom
fix/root-redirect-to-portal
Closed

feat: redirect root path to /portal#298
stabem wants to merge 1 commit intomainfrom
fix/root-redirect-to-portal

Conversation

@stabem
Copy link
Copy Markdown
Owner

@stabem stabem commented Mar 26, 2026

Option A

Make the root path (/) redirect to /portal.

What changes

  • add a root route that responds with 302 Location: /portal
  • add a focused app test for the redirect

Validation

  • npm run typecheck
  • npm run build
  • src/app.test.ts ✅ (47/47)

Why choose this option

  • minimal diff
  • no extra public HTML to maintain
  • fastest path from root domain to the self-serve product

@stabem
Copy link
Copy Markdown
Owner Author

stabem commented Apr 1, 2026

Claude review verdict: APPROVE. Root redirect is a tiny, self-contained route change with matching test coverage and no obvious security/runtime risk. GitHub blocks self-approval on own PRs, so recording the approval verdict here.

Copy link
Copy Markdown
Owner Author

@stabem stabem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review — Root redirect to /portal

Código trivial e correto. Mas conflita com #299 que adiciona uma landing page completa no mesmo endpoint.

Recomendo fechar este e mergear #299 (abordagem mais completa).

Veredito: APPROVE (sem bloqueios)

Copy link
Copy Markdown
Owner Author

@stabem stabem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Code Review — CLEAN

Redirect simples e limpo de //portal. Teste cobre status 302 e header location.

⚠️ Conflita com #299 (landing page). Apenas um pode ser mergeado.

Copy link
Copy Markdown
Owner Author

@stabem stabem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Code Review: CLEAN — No blocking issues

Simple one-liner redirect with test. No issues. ⚠️ Conflicts with #299 — recommend #299 (landing page) for better UX.

Copy link
Copy Markdown
Owner Author

@stabem stabem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review — APPROVED

Redirect simples e limpo. Teste adequado.

⚠️ Conflita com #299 (landing page). Se preferir UX polida, mergear #299.

@stabem
Copy link
Copy Markdown
Owner Author

stabem commented Apr 7, 2026

Closing in favor of #299 (landing page approach).

All reviews on both PRs recommend #299 as the more complete solution.

🤖 Software Factory Pipeline

@stabem stabem closed this Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant