Skip to content

feat: add minimal public landing page at root#299

Open
stabem wants to merge 1 commit intomainfrom
feat/root-landing-page
Open

feat: add minimal public landing page at root#299
stabem wants to merge 1 commit intomainfrom
feat/root-landing-page

Conversation

@stabem
Copy link
Copy Markdown
Owner

@stabem stabem commented Mar 26, 2026

Option B

Serve a minimal public landing page at the root path (/).

What changes

  • add a lightweight HTML landing page at /
  • include links to /portal, /docs, GitHub, /healthz, and /openapi.json
  • add a focused app test for the landing page response

Validation

  • npm run typecheck
  • npm run build
  • src/app.test.ts ✅ (47/47)

Why choose this option

  • better first impression for public visitors
  • makes the root URL useful instead of redirect-only
  • gives a simple overview of what the product is

@stabem
Copy link
Copy Markdown
Owner Author

stabem commented Apr 1, 2026

Claude review verdict: APPROVE. Minimal landing page is static HTML, introduces no user-controlled rendering, and has focused route coverage. GitHub blocks self-approval on own PRs, so recording the approval verdict here.

Copy link
Copy Markdown
Owner Author

@stabem stabem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review — Landing page at root

Sem issues. Landing page estática bem feita, com links para portal, docs e GitHub. Test coverage incluso.

⚠️ Conflito com #298 — ambos adicionam handler para GET /. #298 faz redirect simples para /portal, este #299 serve uma landing page completa. Recomendo mergear #299 (mais completo) e fechar #298.

Veredito: APPROVE (sem bloqueios)

@stabem
Copy link
Copy Markdown
Owner Author

stabem commented Apr 3, 2026

✅ Code review clean. Landing page minimalista com links para portal/docs/GitHub. Teste incluído. Melhor que #298 (redirect simples). Recomendo mergear este e fechar #298.

Copy link
Copy Markdown
Owner Author

@stabem stabem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Code Review — CLEAN

Landing page bem implementada: HTML semântico, dark theme, links para portal/docs/GitHub/healthz/OpenAPI. Testes completos.

Sugestão menor: trocar cache-control: no-store por max-age=3600 em produção.

⚠️ Conflita com #298 (redirect simples). Esta abordagem é mais completa — recomendo mergear esta e fechar #298.

Copy link
Copy Markdown
Owner Author

@stabem stabem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Code Review: CLEAN — No blocking issues

Clean landing page with test coverage. Inline HTML is fine for single-page. no-store cache is appropriate.

⚠️ Conflicts with #298 (redirect approach). Recommend this PR for better UX — actual content vs blind redirect.

@stabem
Copy link
Copy Markdown
Owner Author

stabem commented Apr 3, 2026

Code Review — APPROVED: Landing page minimal e limpa com links para portal/docs/GitHub. Testes incluídos. Cache-control no-store. OK.

Copy link
Copy Markdown
Owner Author

@stabem stabem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review — Clean

Landing page funcional com test. Supersede #298 (redirect simples).

Copy link
Copy Markdown
Owner Author

@stabem stabem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Code Review Automático — APROVADO

Landing page minimalista com teste. Conflita com #298 — esta é mais completa.

Copy link
Copy Markdown
Owner Author

@stabem stabem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review — APPROVED

Landing page mínima e funcional. HTML inline, sem deps externas, teste cobrindo content-type e links.

⚠️ Conflita com #298. Este é mais completo — mergear este e fechar o #298.

@stabem
Copy link
Copy Markdown
Owner Author

stabem commented Apr 7, 2026

Auto-Review Passed — Security: PASS | Correctness: PASS | Scope: PASS

Changes reviewed:

  • src/app.ts — Adds a minimal public HTML landing page at / with links to portal, docs, and GitHub
  • src/app.test.ts — Adds test coverage verifying the landing page serves correctly

Clean implementation: no secrets, proper cache-control headers, scoped to two files, includes test coverage.

🤖 Reviewed by Software Factory Pipeline

@github-actions
Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had activity in the last 14 days. It will be closed in 7 days if no further activity occurs.

@github-actions github-actions Bot added the stale label Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant