feat(browser): add interaction modes and permission rules#1435
Open
Nikolatesla-lj wants to merge 1 commit intostablyai:mainfrom
Open
feat(browser): add interaction modes and permission rules#1435Nikolatesla-lj wants to merge 1 commit intostablyai:mainfrom
Nikolatesla-lj wants to merge 1 commit intostablyai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What changed
browserInteractionModebrowserPermissionDefaultsbrowserSitePermissionRulesbrowserPermissionNoticePolicyWhy
Orca's built-in browser has been automation-first, with mostly hard-coded allow/deny behavior. That works for agents, but it is too rigid for human-in-the-loop browser testing.
This PR introduces a browser interaction model with two explicit modes:
agent: stable, automation-safe defaultshuman: prompt-capable behavior for real browser testing flowsThe result is a formal permission model instead of one-off site exceptions.
Scope
This PR intentionally does not add CLI commands. It only adds the browser permission system itself.
The follow-up CLI PR can expose these settings and site rules without re-implementing any permission logic.
Tests
./node_modules/.bin/vitest run src/shared/browser-permissions.test.ts src/main/browser/browser-session-registry.test.ts src/main/window/attach-main-window-services.test.ts./node_modules/.bin/vitest run src/main/persistence.test.ts src/main/ipc/settings.test.ts./node_modules/.bin/tsc --noEmit -p config/tsconfig.node.json --composite false./node_modules/.bin/tsc --noEmit -p config/tsconfig.web.json --composite false