fix: pr-bug-scan findings from #1415#1464
Conversation
Awaited kill before refresh in orphan handleKillSession; removed duplicate sessions interval from open-gated effect; hoisted kill-confirm Dialog out of PopoverContent; treated missing snapshot + sessi
|
Closing in favor of #1516. This PR was branched off the #1415 merge commit and was 62 commits behind The most concrete silent-revert this would have caused: commit c28c06a (#1451, "focus the right pane after clicking an agent") reworks #1516 re-applies only the four fixer findings (orphan kill race, duplicate sessions interval, hoisted kill Dialog, broadened |
Automated fix-PR from pr-bug-scan for parent #1415.
Fixer summary: Awaited kill before refresh in orphan handleKillSession; removed duplicate sessions interval from open-gated effect; hoisted kill-confirm Dialog out of PopoverContent; treated missing snapshot + sessions error as daemonUnreachable.
Typecheck:
skippedFindings addressed
src/renderer/src/components/status-bar/ResourceUsageStatusSegment.tsx— Orphan kill race re-adds the killed rowsrc/renderer/src/components/status-bar/ResourceUsageStatusSegment.tsx— Duplicate session polling intervalssrc/renderer/src/components/status-bar/ResourceUsageStatusSegment.tsx— Kill confirm Dialog mounted inside PopoverContentsrc/renderer/src/components/status-bar/ResourceUsageStatusSegment.tsx—daemonUnreachablerequires snapshot fetch to have failed at least onceThis PR was generated by the
pr-bug-scanautomation and reviewed by an agent reviewer. Human approval required before merge.