fix: pr-bug-scan findings from #1415 (re-applied on current main)#1516
Open
fix: pr-bug-scan findings from #1415 (re-applied on current main)#1516
Conversation
Re-applies the four ResourceUsageStatusSegment fixes from #1464 on top of current main. Original PR was branched off the #1415 merge commit and would have silently reverted #1451 (focus right pane after clicking an agent), which reworks navigateToTab to thread paneKey through and call activateTabAndFocusPane. Findings: - Orphan kill race re-adds the killed row (await kill before refresh). - Duplicate sessions interval inside open-gated effect (removed). - Kill-confirm Dialog mounted inside PopoverContent (hoisted to sibling). - daemonUnreachable required at least one snapshot failure (also treat null snapshot + sessions error as unreachable).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-applies the four
ResourceUsageStatusSegmentfixes from #1464 on top of current main.#1464 was branched off the #1415 merge commit and was 62 commits behind by the time it landed for review. Its 233-file diff would have silently reverted #1451 (focus right pane after clicking an agent), which reworks
navigateToTabto threadpaneKeythrough and callactivateTabAndFocusPane. This PR is built fresh onorigin/mainand only touchesResourceUsageStatusSegment.tsx.Findings addressed (from #1415 / #1464)
awaitthe kill beforerefreshSessions.Dialogmounted insidePopoverContent— hoisted to a sibling so its lifetime is independent of the popover.daemonUnreachablerequiredmemorySnapshotError !== null, so a sessions failure before the popover ever opened was silent — also treatsnapshot === null+ sessions error as unreachable.Verification
pnpm typecheck:web— clean.pnpm lint— clean (7 pre-existing warnings, 0 new).navigateToTab/activateTabAndFocusPanefrom fix: focus the right pane after clicking an agent #1451 preserved.Closes the intent of #1464; that PR is being closed with an audit-trail comment.