Fix growth estimation for early-year calculations using weighted average#115
Closed
Fix growth estimation for early-year calculations using weighted average#115
Conversation
When less than 60 days into the current year, growth estimates showed zero delta because the code compared predicted values against themselves.
Owner
|
@nicklegan Interesting idea on the weights! ✨ The generated code looks a little bit bloated to be honest. 😅 I kind of also like this simpler approach where it just takes last year's delta. I feel like this is easier to reason about and makes the previous year essentially the dominant factor for how this year's growth is estimated, which generally makes sense I think and is easy to reason about? Maybe @TheZoran has some thoughts who worked in that area. For reference, this pull request is to resolve #113. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When running the tool early in the year (< 60 days), growth estimates
displayed zero delta for all future years, making projections unusable.
Root cause
The estimation logic copied previous year's stats as the prediction,
then calculated
delta = predicted - previous, which was always 0.Solution
Implement weighted average of recent years' growth deltas:
Tested against short-running repos (< 2 years) - correctly shows
"Growth estimation unavailable" message.