add cache-control at 15 minutes max for v1 handler - #358
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds caching for the v1 lumens endpoint with a 5-minute fresh period and 10-minute stale-revalidation window.
Changes:
- Adds the
Cache-Controlresponse header. - Verifies the header through integration testing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
backend/lumens.ts |
Configures caching for the v1 handler. |
test/tests/integration/backend.ts |
Tests the cache header. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Preview is available here: |
marcelosalloum
approved these changes
Jul 22, 2026
marcelosalloum
left a comment
marcelosalloum
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Plz, feel free to merge it after addressing the comment below.
|
Preview is available here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://stellarfoundation.slack.com/archives/C06KTGUULUF/p1784131727014119