Skip to content

add cache-control at 15 minutes max for v1 handler #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeesunikim merged 2 commits into from
Jul 22, 2026
Merged

add cache-control at 15 minutes max for v1 handler #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b40b63d
add cache-control at 15 minutes max for v1 handler
jeesunikim Jul 21, 2026
bd1f9e4
exact match the cache-control description
jeesunikim Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions backend/lumens.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ export async function v1Handler(_: any, res: Response, next: NextFunction) {
try {
const cachedData = await getOrThrow(redisClient, "lumensV1");
const obj: CachedData = JSON.parse(cachedData);
res.setHeader(
"Cache-Control",
"public, max-age=300, stale-while-revalidate=600",
);
res.json(obj);
} catch (e) {
next(e);
Expand Down
12 changes: 11 additions & 1 deletion test/tests/integration/backend.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,17 @@ describe("integration", function () {

describe("backend api endpoints", function () {
it("/api/lumens should return successfuly with data", async function () {
let { body } = await request(app).get("/api/lumens").expect(200);
let { body, headers } = await request(app)
.get("/api/lumens")
.expect(200)
.expect(
"Cache-Control",
"public, max-age=300, stale-while-revalidate=600",
);

chai
.expect(headers["cache-control"])
.to.include("public, max-age=300, stale-while-revalidate=600");

chai.expect(body).to.be.an("object");
chai.expect(Object.keys(body).length).to.not.equal(0);
Expand Down
Loading