Add Stellar address link to README - #119
Conversation
Added a link to a Stellar address in the README.
|
🤖 Automated message from Kaan's Automated Triage Bot. 👀 Picked this up — a review will follow shortly. |
There was a problem hiding this comment.
Pull request overview
Adds a Blockchair link for a Stellar account to the repository README.
Changes:
- Adds a Stellar address URL, but it differs from the public key in the PR description.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| --- | ||
|
|
||
| > **Note:** This repository is not in scope for the Stellar Development Foundation bug bounty program. Vulnerabilities found in this repo are not eligible for rewards. | ||
| https://blockchair.com/stellar/address/GCWZQFFE2PU76RPJQ6HU3Z7N5TAPLKQCL6TELGB7USQUQTFGSQSOIVML |
|
🤖 Automated message from Kaan's Automated Triage Bot. Thanks for the PR. I also want to say that the key handling in your description is good practice: reading the secret from an environment variable and checking it against the expected public key is exactly right. I cannot merge this one. A maintainer must decide it. Here is what I found:
If you want a donation or funding address here, please tell us in the README text whose account it is and what it is for. A @kaankacar this one needs your call. |
Added a link to a Stellar address in the README.import os
from stellar_sdk import Keypair
PUBLIC_KEY = "GDBJKQVLJFJJY2M4OUX563X5FSOOI3FS7DDPDM7TISC3ZBDRE67CFTWG"
Store the secret key in an environment variable instead of source code.
SECRET_KEY = os.environ.get("STELLAR_SECRET_KEY")
if not SECRET_KEY:
raise RuntimeError("STELLAR_SECRET_KEY is not set")
keypair = Keypair.from_secret(SECRET_KEY)
Verify that the secret corresponds to the expected public account.
if keypair.public_key != PUBLIC_KEY:
raise ValueError("Secret key does not match the expected Stellar public key")
print("Stellar account:", keypair.public_key)
print("Key verified successfully.")