Skip to content

Add Stellar address link to README - #120

Open
EHESPO wants to merge 1 commit into
stellar:mainfrom
EHESPO:patch-3
Open

Add Stellar address link to README#120
EHESPO wants to merge 1 commit into
stellar:mainfrom
EHESPO:patch-3

Conversation

@EHESPO

@EHESPO EHESPO commented Aug 28, 2026

Copy link
Copy Markdown

Added a link to a Stellar address in the README.import os
from stellar_sdk import Keypair

PUBLIC_KEY = "GDBJKQVLJFJJY2M4OUX563X5FSOOI3FS7DDPDM7TISC3ZBDRE67CFTWG"

Store the secret key in an environment variable instead of source code.

SECRET_KEY = os.environ.get("STELLAR_SECRET_KEY")

if not SECRET_KEY:
raise RuntimeError("STELLAR_SECRET_KEY is not set")

keypair = Keypair.from_secret(SECRET_KEY)

Verify that the secret corresponds to the expected public account.

if keypair.public_key != PUBLIC_KEY:
raise ValueError("Secret key does not match the expected Stellar public key")

print("Stellar account:", keypair.public_key)
print("Key verified successfully.")

Added a link to a Stellar address in the README.
Copilot AI balanced review requested due to automatic review settings August 28, 2026 22:05
@kaankacar

Copy link
Copy Markdown
Contributor

🤖 Automated message from Kaan's Automated Triage Bot.

👀 Picked this up — a review will follow shortly.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a Stellar account link to the repository documentation.

Changes:

  • Adds a Blockchair URL for a Stellar address.
  • The address conflicts with the public key in the PR description.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread README.md
---

> **Note:** This repository is not in scope for the Stellar Development Foundation bug bounty program. Vulnerabilities found in this repo are not eligible for rewards.
https://blockchair.com/stellar/address/GCWZQFFE2PU76RPJQ6HU3Z7N5TAPLKQCL6TELGB7USQUQTFGSQSOIVML
@kaankacar

Copy link
Copy Markdown
Contributor

🤖 Automated message from Kaan's Automated Triage Bot.

Thanks for the PR. The key handling in your description is good practice: you read the secret from an environment variable and check it against the expected public key.

This PR has the same one-line diff as #119 and #118. I cannot merge it, and a maintainer must decide it. My findings:

  • The diff adds a bare explorer URL to the README. There is no label and no sentence about what the account is for. An unexplained address in a project README reads as a payment destination.
  • The linked address is GCWZ…IVML. The public key in your description is GDBJ…FTWG. These are two different accounts. Copilot raised this too, and it is correct.
  • GDBJ…FTWG does not exist on Stellar mainnet. Horizon returns 404 for it.
  • GCWZ…IVML is live on mainnet. Nothing ties it to this repo or to you. It has no home domain and no stellar.expert directory entry. eheps.com serves no .well-known/stellar.toml.

Please also close two of the three PRs and keep one. If you want a donation or funding address here, tell us in the README text whose account it is and what it is for. A stellar.toml on eheps.com that lists the account would settle ownership.

@kaankacar this one needs your call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants