Skip to content

ACM-33047 WizTextArea loses formatting when shown in Review step#6014

Closed
jeswanke wants to merge 1 commit intostolostron:mainfrom
jeswanke:ACM-33047-WizTextArea-loses-formatting-when-shown-in-Review-step
Closed

ACM-33047 WizTextArea loses formatting when shown in Review step#6014
jeswanke wants to merge 1 commit intostolostron:mainfrom
jeswanke:ACM-33047-WizTextArea-loses-formatting-when-shown-in-Review-step

Conversation

@jeswanke
Copy link
Copy Markdown
Contributor

@jeswanke jeswanke commented Apr 21, 2026

📝 Summary

CleanShot 2026-04-21 at 15 13 23@2x

Ticket Summary (Title):
ACM-33047 WizTextArea loses formatting when shown in Review step

Ticket Link:
https://redhat.atlassian.net/browse/ACM-33047

Type of Change:

  • 🐞 Bug Fix
  • ✨ Feature
  • 🔧 Refactor
  • 💸 Tech Debt
  • 🧪 Test-related
  • 📄 Docs

✅ Checklist

General

  • PR title follows the convention (e.g. ACM-12340 Fix bug with...)
  • Code builds and runs locally without errors
  • No console logs, commented-out code, or unnecessary files
  • All commits are meaningful and well-labeled
  • All new display strings are externalized for localization (English only)
  • (Nice to have) JSDoc comments added for new functions and interfaces

If Feature

  • UI/UX reviewed (if applicable)
  • All acceptance criteria met
  • Unit test coverage added or updated
  • Relevant documentation or comments included

If Bugfix

  • Root cause and fix summary are documented in the ticket (for future reference / errata)
  • Fix tested thoroughly and resolves the issue
  • Test(s) added to prevent regression

🗒️ Notes for Reviewers

Signed-off-by: John Swanke <jswanke@redhat.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 21, 2026

Warning

Rate limit exceeded

@jeswanke has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 21 minutes and 52 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 21 minutes and 52 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: be7e1414-3e73-4d06-a3e0-3640a7766240

📥 Commits

Reviewing files that changed from the base of the PR and between d9cc7e4 and 7731227.

📒 Files selected for processing (1)
  • frontend/packages/react-form-wizard/src/review/ReviewStep.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 21, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeswanke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown
Contributor

@KevinFCormier KevinFCormier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see YAML formatting specifically was fixed in the other PR #6011.

This fix does not preserve leading spaces or multiple consecutive spaces. Very HTML style.

I guess this matches what we do for Policy currently.

Image

But I see we don't preserve anything when we display them on Policy Set.

Image

EDIT: Could you please look into this and see if we can make it consistent for those 2 cases? (react-form-wizard should be kept separate since we're going to spin it out again.)

@jeswanke
Copy link
Copy Markdown
Contributor Author

duplicating with ACM-33048

@jeswanke jeswanke closed this Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants