Skip to content

ACM-33047 WizTextArea loses formatting when shown in Review step #6014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jeswanke wants to merge 1 commit into from
Closed

ACM-33047 WizTextArea loses formatting when shown in Review step #6014

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions frontend/packages/react-form-wizard/src/review/ReviewStep.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,6 +706,20 @@ function renderReviewInputDescriptionContent(node: WizardInputDomNode): ReactNod
return <></>
}

/** When review value is a plain string with newlines, show each segment on its own line. */
function renderReviewValueWithNewlines(valueContent: ReactNode): ReactNode {
if (typeof valueContent === 'string' && valueContent.includes('\n')) {
const lines = valueContent.split('\n')
return lines.map((line, index) => (
<Fragment key={index}>
{index > 0 ? <br /> : null}
{line}
</Fragment>
))
}
return valueContent
}

/** Base margin 32px; each nested ARRAY_INPUT adds 2px. */
function reviewArrayInstanceMarginLeft(arrayInputNesting: number): number {
return 32 + 2 * arrayInputNesting
Expand Down Expand Up @@ -863,13 +877,13 @@ function renderReviewInputRows(nodes: readonly WizardInputDomNode[], ctx: Review
onPenIconClick={() => onReviewEdit(inputNode, 'navigate')}
onArrowClick={yamlVisible ? () => onReviewEdit(inputNode, 'highlight') : undefined}
>
{valueContent}
{renderReviewValueWithNewlines(valueContent)}
</ReviewPenHoverZone>
) : (
<>
<DescriptionListTerm>{termContent}</DescriptionListTerm>
<DescriptionListDescription id={inputNode.id ?? ''}>
<span className="wizard-review-inline-value">{valueContent}</span>
<span className="wizard-review-inline-value">{renderReviewValueWithNewlines(valueContent)}</span>
</DescriptionListDescription>
</>
)}
Expand Down
Loading