Skip to content

Allow hiding a quest type from the Uh... menu#6806

Open
VeryUsual wants to merge 3 commits intostreetcomplete:masterfrom
VeryUsual:master
Open

Allow hiding a quest type from the Uh... menu#6806
VeryUsual wants to merge 3 commits intostreetcomplete:masterfrom
VeryUsual:master

Conversation

@VeryUsual
Copy link
Copy Markdown

image image

This pull request allows hiding a quest type from the "Uh..." menu. Fixes #6765.

@westnordost
Copy link
Copy Markdown
Member

See my comment in the linked issue.

@VeryUsual VeryUsual marked this pull request as draft April 8, 2026 20:05
@VeryUsual VeryUsual marked this pull request as ready for review April 8, 2026 20:21
Copy link
Copy Markdown
Member

@westnordost westnordost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it already popped up in the connected issue, users will be confused where is the difference between "Hide" and "Disable". One issue is, that "quest type" and "quest" are understood somewhat interchangeably, while actually, a "quest" is just one instance of a "quest type". E.g. "Disable this quest", "Hide this quest". Very difficult to get that across in just a button label.

To explain this, buttons labeled "Disable" and "Hide this quest" are not enough. Rather, below the quest_leave_new_note_description one needs an extra paragraph that says something like "Alternatively, you can disable all quests of this type." and maybe optionally "This can be changed again in the settings." if it doesn't get too long. (Users should still read it. Too much text will be ignored.)


Also, note, if possible, use strings that already exist and name the strings consistently so they can be next to each other in the strings.xml file.

@HolgerJeromin
Copy link
Copy Markdown
Contributor

Perhaps this could work

hide the quest

never ask again

@matkoniecz
Copy link
Copy Markdown
Member

"never ask again this type of question?"

@matkoniecz
Copy link
Copy Markdown
Member

To explain this, buttons labeled "Disable" and "Hide this quest" are not enough. Rather, below the quest_leave_new_note_description one needs an extra paragraph that says something like "Alternatively, you can disable all quests of this type." and maybe optionally "This can be changed again in the settings." if it doesn't get too long. (Users should still read it. Too much text will be ignored.)

maybe confirmation dialog?

@westnordost
Copy link
Copy Markdown
Member

"Never ask again" leaves room for interpretation (ask again what, this confirmation dialog?), written out, it is too long for a button text.

maybe confirmation dialog?

Explaining what the button does after the user having tapped it doesn't sound like a good idea.

@matkoniecz
Copy link
Copy Markdown
Member

Explaining what the button does after the user having tapped it doesn't sound like a good idea.

I thought rather of a reminder that it will get rid of all such quests until setting is changed again.

Though, I guess, people typically do not read them anyway. Maybe put "back" and "hide all questions asking this?" as buttons on dialog?

@westnordost
Copy link
Copy Markdown
Member

What dialog?

I am perplexed why everyone seems to completely ignore my comment where I wrote what exactly needs to be done to get this PR merged and keeps coming with new suggestions instead (here and in the connected issue).

If you find the solution described in that comment inadequate, please say so, and why!
Otherwise, I just get the impression you want to block this PR going forward with comments like "oh but we could also do this instead, or that instead...!"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow hiding a quest type from the Uh... menu

4 participants