Conversation
Jah-yee
force-pushed
the
codex/live-rendering-toggle
branch
from
September 11, 2026 14:19
56e5cf4 to
9c37f7c
Compare
Jah-yee
force-pushed
the
codex/live-rendering-toggle
branch
from
September 11, 2026 14:35
9c37f7c to
c27f082
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
isLivePicturewas only consulted whenpresentPicture()ran. Once an overlay was visible, changing Live rendering did not select a new picture source:Change
The existing screenshot and live-seeding paths are reused, so behavior outside a mid-effect setting change is unchanged.
Lifecycle edges
live -> still -> livechanges converge on the latest settingstartTask, install its receiver, or invalidate the newer filterThe capture-cancellation behavior now on
mainis retained: disabling, sleeping, or stopping the app cancels the underlying screenshot. A normal animated effect end still only discards its cache, so this PR limits its additional guarantee to presentation state rather than changingScreenSnapshotterownership.Validation
git diff --checkmainThe change has not been exercised during a physical lid-close cycle.
Coordination
PR #16 also changes stream filter rebuilding, so the two PRs have a small textual conflict in
ScreenStreamer. The tested resolution keeps this PR's cancellation and start-generation guards together with #16's fail-closed exclusion helper and post-rebuild filter readiness check.