Conversation
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Both capture paths built their self-exclusion list by comparing bundle identifiers. If ScreenCaptureKit had not listed Mac Duo yet, or reported no bundle identifier, that list could be empty and capture would continue. A screenshot could then contain a lingering overlay, while a live stream could feed the overlay back into itself.
Change
SCShareableContentbefore constructing a filterisStartedstuckThis intentionally fails closed: when ScreenCaptureKit cannot prove that the current process is excluded, Mac Duo skips that capture instead of risking recursive or stale overlay content. A transient miss at the trigger boundary can make that lid cycle fall back to a still seed; the next normal cycle retries.
Validation
git diff --checkmain, retaining the capture-cancellation guards merged in PR Makes the lid effect shut down more cleanly #3Coordination
PR #15 also changes the asynchronous stream-start and filter-rebuild lifecycle, so the two PRs have a small textual conflict in
ScreenStreamer. The tested resolution keeps #15's start-generation checks together with this PR's fail-closed exclusion helper and post-rebuild filter readiness check.