-
Notifications
You must be signed in to change notification settings - Fork 74
Support virtio-console #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shengwen-tw
wants to merge
4
commits into
sysprog21:master
Choose a base branch
from
shengwen-tw:virtio-console
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| #include <stdbool.h> | ||
| #include <stdint.h> | ||
| #include <stdlib.h> | ||
| #include <termios.h> | ||
| #include <unistd.h> | ||
|
|
||
| #include "console.h" | ||
|
|
||
| #define CONSOLE_ESCAPE 1 /* Ctrl-a */ | ||
|
|
||
| static struct termios saved_termios; | ||
| static int terminal_fd = -1; | ||
| static int output_fd = -1; | ||
| static bool escape_pending; | ||
|
|
||
| static void host_console_restore(void) | ||
| { | ||
| if (terminal_fd >= 0) | ||
| tcsetattr(terminal_fd, TCSANOW, &saved_termios); | ||
| } | ||
|
|
||
| void host_console_setup(int in_fd, int out_fd) | ||
| { | ||
| struct termios termios; | ||
|
|
||
| output_fd = out_fd; | ||
| if (!isatty(in_fd) || tcgetattr(in_fd, &saved_termios) < 0) | ||
| return; | ||
|
|
||
| termios = saved_termios; | ||
| termios.c_lflag &= ~(ICANON | ECHO | ISIG); | ||
| if (tcsetattr(in_fd, TCSANOW, &termios) < 0) | ||
| return; | ||
|
|
||
| terminal_fd = in_fd; | ||
| atexit(host_console_restore); | ||
| } | ||
|
|
||
| ssize_t host_console_read(int fd, void *buf, size_t len) | ||
| { | ||
| ssize_t nread = read(fd, buf, len); | ||
| uint8_t *bytes = buf; | ||
|
|
||
| if (nread <= 0) | ||
| return nread; | ||
|
|
||
| for (ssize_t i = 0; i < nread; i++) { | ||
| if (escape_pending && bytes[i] == 'x') { | ||
| if (output_fd >= 0) { | ||
| ssize_t written = write(output_fd, "\n", 1); | ||
| (void) written; | ||
| } | ||
| exit(0); | ||
| } | ||
| escape_pending = bytes[i] == CONSOLE_ESCAPE; | ||
| } | ||
|
|
||
| return nread; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| #pragma once | ||
|
|
||
| #include <stddef.h> | ||
| #include <sys/types.h> | ||
|
|
||
| void host_console_setup(int in_fd, int out_fd); | ||
| ssize_t host_console_read(int fd, void *buf, size_t len); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: The
SEMU_CONSOLE ?= virtiodefault flips the build from the previous primary 8250 UART console to virtio-console, but the selection is mutually exclusive: whenSEMU_CONSOLEis left atvirtiotheelsebranch is taken anduart.ois not compiled at all. This contradicts the PR description, which states the existing 8250 UART "remains the primary console and early boot path" and that virtio-console is a secondary console. With the default, the 8250 console (and its early-boot UART path) is silently removed from the default build, and the backend cannot be a "secondary" console since only one console object is built and main.c dispatches via#if SEMU_HAS(UART8250) ... #else virtio_console ... #endif. Keepuart8250as the default (or build both backends so virtio can genuinely be secondary) unless removing the 8250 primary console is the intended behavior.Prompt for AI agents