Skip to content

fix: return errors for uninitialized temper reads #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
taigrr wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: return errors for uninitialized temper reads #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions temper_linux_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,32 @@ func TestCloseSafeOnNilAndZeroValue(t *testing.T) {
}
}

func TestReadCSafeOnNilAndZeroValue(t *testing.T) {
var nilTemper *Temper
if _, err := nilTemper.ReadC(); err != errUninitializedTemper {
t.Fatalf("ReadC() on nil Temper error = %v, want %v", err, errUninitializedTemper)
}

var zero Temper
if _, err := zero.ReadC(); err != errUninitializedTemper {
t.Fatalf("ReadC() on zero-value Temper error = %v, want %v", err, errUninitializedTemper)
}
}

func TestReadFWithContextSafeOnNilAndZeroValue(t *testing.T) {
ctx := context.Background()

var nilTemper *Temper
if _, err := nilTemper.ReadFWithContext(ctx); err != errUninitializedTemper {
t.Fatalf("ReadFWithContext() on nil Temper error = %v, want %v", err, errUninitializedTemper)
}

var zero Temper
if _, err := zero.ReadFWithContext(ctx); err != errUninitializedTemper {
t.Fatalf("ReadFWithContext() on zero-value Temper error = %v, want %v", err, errUninitializedTemper)
}
}

func TestIsInputDevice(t *testing.T) {
if isInputDevice("temper999") {
t.Error("expected false for non-existent hidraw device")
Expand Down
7 changes: 7 additions & 0 deletions temperctx_linux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,20 @@ package temper
import (
"context"
"encoding/hex"
"errors"
"fmt"
"strconv"
)

var errUninitializedTemper = errors.New("temper device is uninitialized")

// ReadCWithContext reads the internal sensor temperature in Celsius,
// respecting the provided context for cancellation/timeout.
func (t *Temper) ReadCWithContext(ctx context.Context) (float32, error) {
if t == nil || t.reader == nil || t.writer == nil {
return 0, errUninitializedTemper
}

t.lock.Lock()
defer t.lock.Unlock()

Expand Down