chore: exclude e2e package from root test command#273
Merged
Conversation
IzumiSy
force-pushed
the
chore/exclude-e2e-from-root-test
branch
from
4528edb to
3a4b9c7
Compare
This reverts commit d5607b6.
erickteowarang
approved these changes
May 19, 2026
| run: pnpm exec turbo run lint type-check --filter=e2e | ||
| - name: Run E2E tests | ||
| run: pnpm --filter e2e test | ||
| run: pnpm --filter e2e test:e2e |
Contributor
There was a problem hiding this comment.
I don't think you need to still keep the --filter e2e here but it's a minor issue
Contributor
Author
There was a problem hiding this comment.
It finally needs -r or package specification here as it is. Let me keep it go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E2E tests require external services and environment setup (Playwright browsers, Tailor Platform credentials), so they should not run as part of
pnpm testfrom the root.This adds
--filter='!e2e'to the roottestscript to exclude the e2e package. E2E tests are run separately via the dedicatedci-e2e.yamlworkflow.