Skip to content

chore: exclude e2e package from root test command #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IzumiSy merged 5 commits into from
May 19, 2026
+8 −3
Merged

chore: exclude e2e package from root test command #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3a4b9c7
chore: exclude e2e package from root test command
IzumiSy May 19, 2026
d5607b6
Tweak
IzumiSy May 19, 2026
da03f50
Revert "Tweak"
IzumiSy May 19, 2026
1d73fe5
refactor: rename e2e test script to test:e2e to avoid turbo conflict
IzumiSy May 19, 2026
bb6b95b
ci: use test:e2e script in ci-e2e workflow
IzumiSy May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/ci-e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,10 @@ jobs:
run: pnpm install
- name: Build packages
run: pnpm exec turbo run build
- name: Lint & Type-check
run: pnpm exec turbo run lint type-check --filter=e2e
- name: Run E2E tests
run: pnpm --filter e2e test
run: pnpm --filter e2e test:e2e
Copy link
Copy Markdown
Contributor

@erickteowarang erickteowarang May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need to still keep the --filter e2e here but it's a minor issue

Copy link
Copy Markdown
Contributor Author

@IzumiSy IzumiSy May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It finally needs -r or package specification here as it is. Let me keep it go.

env:
VITE_TAILOR_APP_URL: ${{ secrets.E2E_TAILOR_APP_URL }}
VITE_TAILOR_CLIENT_ID: ${{ secrets.E2E_TAILOR_CLIENT_ID }}
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/ci-packages.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ on:
- "packages/**"
- "examples/**"
- "docs/**"
- "package.json"
- "pnpm-lock.yaml"
- "pnpm-workspace.yaml"
- ".github/workflows/ci-packages.yaml"
- ".github/actions/ci/action.yaml"

Expand Down
4 changes: 2 additions & 2 deletions e2e/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
"private": true,
"type": "module",
"scripts": {
"test": "playwright test",
"test:ui": "playwright test --ui",
"test:e2e": "playwright test",
"test:e2e:ui": "playwright test --ui",
"dev": "vite --config app/vite.config.ts",
"deploy:backend": "cd backend && tailor-sdk apply --workspace-id $TAILOR_PLATFORM_WORKSPACE_ID --yes"
},
Expand Down
Loading