Retry flaky Z2MIntegrationTests once on Full CI#103
Open
tashda wants to merge 1 commit into
Open
Conversation
Pass -retry-tests-on-failure -test-iterations 2 to the unit+integration xcodebuild step. Real regressions still fail twice; one-off WS connect timeouts to the mock bridge (races between back-to-back tests and the bridge replaying ~173 retained messages on each new client) absorb a single retry. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
6a25a9d). Last night (May 6) failed on a different, genuinely flaky test:testReceivesBridgeDevicestimed out atclient.connect(url:)for 18.9 s. The mock bridge replays ~173 retained messages on every new WS client, and back-to-back integration tests occasionally race the previous client's teardown on the shared GitHub runner.-retry-tests-on-failure -test-iterations 2to the unit+integration xcodebuild step so a one-off flake gets a single retry. Genuine regressions still fail twice in a row and surface red.Test plan
CI (Full)from the Actions tab onmainafter merge and confirm the unit+integration job is green.🤖 Generated with Claude Code