Skip to content

Retry flaky Z2MIntegrationTests once on Full CI #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tashda wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Retry flaky Z2MIntegrationTests once on Full CI #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/ci-full.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,12 @@ jobs:
# (keychain/concurrency issues that only fail on GitHub runners) —
# except Z2MIntegrationTests, which Full CI explicitly runs because
# we now have the mock bridge up. See xctestplans/README.md.
# Z2MIntegrationTests talks to the live mock bridge over a real
# WebSocket. On GitHub's shared runners, back-to-back tests
# occasionally race the previous client's teardown against the
# bridge replaying ~173 retained messages, causing a connect
# timeout. Retry once per test on failure to absorb that flake
# without masking real regressions — a true bug will fail twice.
set -o pipefail
xcodebuild test-without-building \
-project Shellbee.xcodeproj -scheme "$SCHEME" \
Expand All @@ -143,6 +149,7 @@ jobs:
-skip-testing:"ShellbeeTests/NotificationPreferencesTests" \
-skip-testing:"ShellbeeTests/ConnectionConfigTests/testSecondLoadAfterLegacyMigrationStillReturnsToken" \
-skip-testing:"ShellbeeTests/Z2MIntegrationTests/testReloadedPersistedConfigConnectsAndReceivesBridgeInfo" \
-retry-tests-on-failure -test-iterations 2 \
-resultBundlePath "$DERIVED_DATA/UnitTests.xcresult" \
CODE_SIGNING_ALLOWED=NO | tee test-unit.log

Expand Down
Loading