Repository navigation
Windows 专用打包 + 中英双语与设置页 - #1
Conversation
Drop Linux/macOS demo build notes, keep Windows tooling, and add Buildkite scripts to package MSI on a Windows agent queue. Co-authored-by: 绿岸公式 <chinesejar@gmail.com>
Remove Buildkite packaging scripts and document/use a windows-latest GitHub Actions workflow to build and publish MSI artifacts. Co-authored-by: 绿岸公式 <chinesejar@gmail.com>
cursor
Bot
changed the title
Avoid pinning an older Chocolatey WiX version that fails when a newer build is already present; only install when candle/light are missing. Co-authored-by: 绿岸公式 <chinesejar@gmail.com>
Detect system locale (zh → Chinese, otherwise English), localize the UI, and move language/theme controls into a dedicated Settings section. Co-authored-by: 绿岸公式 <chinesejar@gmail.com>
cursor
Bot
changed the title
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5cbf876b1f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| $wixBins = Get-ChildItem -Path @( | ||
| "${env:ProgramFiles(x86)}\WiX Toolset*\bin", | ||
| "${env:ProgramFiles}\WiX Toolset*\bin" | ||
| ) -Directory -ErrorAction SilentlyContinue | | ||
| Select-Object -ExpandProperty FullName |
There was a problem hiding this comment.
Get-ChildItem -Path ...\bin -Directory enumerates child directories inside each bin, rather than the matched bin directory itself (PowerShell documentation). Consequently, this adds no location containing candle.exe or light.exe to PATH. On a runner where WiX is installed but is not already on PATH—or after the fallback Chocolatey install—the second check still fails and aborts the workflow before an MSI can be produced. Enumerate the WiX Toolset* directories and append bin, or use the known bin paths directly.
Useful? React with 👍 / 👎.
| if (-not (Test-Path "wix\main.wxs")) { | ||
| cargo wix init --force | ||
| } |
There was a problem hiding this comment.
wix/main.wxs is absent from the tracked tree (including a repo-wide search for installer sources), so every clean Actions runner enters this branch. cargo wix init generates fresh GUIDs each time; its default template places one in Product UpgradeCode and uses MajorUpgrade (template). MSIs from separate tagged runs therefore have different upgrade identities, so a later release will not recognize and upgrade/uninstall its predecessor correctly. Commit a generated/customized WXS with a stable UpgradeCode and have CI build from it.
Useful? React with 👍 / 👎.
Remove TitleBar tabs; open Settings from a titlebar gear button. Ship WiX MSI with Start Menu + Desktop shortcuts and product icon, without adding the install dir to PATH. Rebased onto main after PR #1 squash-merge to clear conflicts. Co-authored-by: 绿岸公式 <chinesejar@gmail.com>
2 participants
变更
Windows 专用
windows-latest）打 MSI：push/PR 上传 artifact，v*tag 发 Release多语言与设置
src/i18n.rs：中文 / English 字符串表sys-locale读系统语言：以zh开头用中文，否则英文main硬编码改为设置页控制（默认深色）