Skip to content

fix: add missing privacy lang strings for drawer preferences (#235)#236

Merged
rmady merged 1 commit into
trema-tech:mainfrom
guillogo:fix/issue-235-privacy-missing-lang-strings
May 15, 2026
Merged

fix: add missing privacy lang strings for drawer preferences (#235)#236
rmady merged 1 commit into
trema-tech:mainfrom
guillogo:fix/issue-235-privacy-missing-lang-strings

Conversation

@guillogo

Copy link
Copy Markdown
Contributor

Add two missing lang strings referenced in classes/privacy/provider.php but absent from lang/en/theme_trema.php:

…ech#235)

Add two missing lang strings referenced in classes/privacy/provider.php
but absent from lang/en/theme_trema.php:
- privacy:metadata:preference:draweropenindex
- privacy:metadata:preference:draweropenblock
Without these strings, the PHPUnit privacy provider test fails with a
debugging notice from get_string().
Fixes trema-tech#235
@guillogo guillogo force-pushed the fix/issue-235-privacy-missing-lang-strings branch from e0d7279 to d14878b Compare May 15, 2026 19:32
@rmady rmady added the bug Something isn't working label May 15, 2026
@rmady rmady merged commit 4167540 into trema-tech:main May 15, 2026
@rmady

rmady commented May 15, 2026

Copy link
Copy Markdown
Contributor

Thanks for the contribution @guillogo.
I will do another release as soon as possible and add this fix to it.

Kind regards,
Rodrigo Mady

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Privacy provider test fails: missing lang strings for drawer preferences

2 participants