Fix Symmetry error - #172
Merged
Merged
Conversation
Fix the issue where symmetry elements were destroyed by setting the distanceFromBoundary field in the node type away from zero for nodes along the symmetry boundary, since they are no longer on a boundary. This made minor changes in the smoothing since different nodes were allowed to move, so the PacMan benchmark data has been changed.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #172 +/- ##
==========================================
- Coverage 78.29% 78.26% -0.04%
==========================================
Files 83 83
Lines 12385 12388 +3
Branches 2 2
==========================================
- Hits 9697 9695 -2
- Misses 2688 2693 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the issue where symmetry elements were destroyed by setting the distanceFromBoundary field in the node type away from zero for nodes along the symmetry boundary, since they are no longer on a boundary. This made minor changes in the smoothing since different nodes were allowed to move, so the PacMan benchmark data has been changed.