Skip to content

Fix Symmetry error #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewwinters5000 merged 1 commit into from
Aug 12, 2026
Merged

Fix Symmetry error #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Benchmarks/BenchmarkData/PacMan.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
1
94 115 208 0
3.39246E-02
1.21406E+00
1.10216E+00
1.40356E+00
2.80011E-02
7.56617E+01
1.06337E+02
1.21083E+00
1.09944E+00
1.39822E+00
2.79568E-02
7.56404E+01
1.06188E+02
2 changes: 1 addition & 1 deletion Source/Mesh/Connections.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ SUBROUTINE makeNodeToElementConnections( mesh, errorCode )
! grid based method is set to 11.
! -----------------------------------------------------
!
errorCode = NONE
errorCode = A_OK_ERROR_CODE
CALL deallocateNodeToElementConnections

numNodes = mesh % nodes % COUNT()
Expand Down
16 changes: 12 additions & 4 deletions Source/Mesh/MeshGeneratorMethods.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2359,6 +2359,16 @@ SUBROUTINE ReflectMesh( mesh, symmetryCurve)
newElement % boundaryInfo % bCurveName(j) = NO_BC_STRING
oldElement % boundaryInfo % bCurveFlag(j) = NONE
newElement % boundaryInfo % bCurveFlag(j) = NONE
!
! -------------------------------------------------------------------------
! Mark that the nodes that were on the symmetry boundary are off of it now.
! The amount doesn't matter.
! -------------------------------------------------------------------------
!
oldElement % nodes(edgeMap(1,j)) % node % distToBoundary = 1.0
oldElement % nodes(edgeMap(2,j)) % node % distToBoundary = 1.0
newElement % nodes(edgeMap(1,j)) % node % distToBoundary = 1.0
newElement % nodes(edgeMap(2,j)) % node % distToBoundary = 1.0
END IF
END DO

Expand Down Expand Up @@ -2386,8 +2396,7 @@ SUBROUTINE ReflectMesh( mesh, symmetryCurve)

DO WHILE( .NOT. nodeItr % isAtEnd() )

obj => nodeItr % object()
CALL castToSMNode(obj,oldNode)
CALL castToSMNode(nodeItr % object(),oldNode)
!
IF ( oldNode % bCurveID /= bCurveID ) THEN !Skip over nodes along the symmetry axis
!
Expand All @@ -2414,7 +2423,7 @@ SUBROUTINE ReflectMesh( mesh, symmetryCurve)
!
DO i = 1, numElementsForNode(oldNode % id)
e => elementsForNodes(i, oldNode % id) % element
DO j = 1, e % eType
DO j = 1, e % eType
IF ( ASSOCIATED(e % nodes(j) % node, oldNode) ) THEN
e % nodes(j) % node => newNode
e % boundaryInfo % nodeIDs(j) = newNode % id
Expand Down Expand Up @@ -2479,7 +2488,6 @@ SUBROUTINE ReflectMesh( mesh, symmetryCurve)
! Clean up
! --------
!
CALL releaseFTLinkedListClass(newNodes)
CALL releaseFTLinkedListClass(savedElements)
CALL deallocateNodeToElementConnections

Expand Down
1 change: 1 addition & 0 deletions Source/MeshObjects/SMMeshObjects.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,6 +515,7 @@ FUNCTION SMElementCopy(source) RESULT(copy)
IF ( ALLOCATED(source % nodes) ) THEN
copy % nodes = source % nodes
DO j = 1, copy % eType
copy % nodes(j) % node => source % nodes(j) % node
CALL copy % nodes(j) % node % retain()
END DO
END IF
Expand Down