feat(google_adk): add ADK-111, MCPToolset with no tool_filter - #51
Merged
Conversation
Closes Class 2 of the tool access-control detection scoping — Google ADK genuinely has a 'true restriction' semantic (unlike Claude/OpenAI's permission-style allow-lists), making 'no explicit filter' the correct risk signal. MCPToolset connects an agent to a remote MCP server's entire tool catalog, which is not enumerable from source and can change whenever the server updates. tool_filter= is the only mechanism narrowing that catalog to a named allow-list. Mirrored byte-for-byte from the engine fixture (verified via diff, no output — fully in sync).
This was referenced Aug 24, 2026
ivanpaghubasan
marked this pull request as ready for review
August 25, 2026 02:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Class 2 of the tool access-control detection scoping — Google ADK genuinely has a 'true restriction' semantic (unlike Claude/OpenAI's permission-style allow-lists), making 'no explicit filter' the correct risk signal.
MCPToolset connects an agent to a remote MCP server's entire tool catalog, which is not enumerable from source and can change whenever the server updates. tool_filter= is the only mechanism narrowing that catalog to a named allow-list.
Mirrored byte-for-byte from the engine fixture (verified via diff, no output — fully in sync).