Skip to content

feat(db): add PLN to supported currencies - #189

Open
reall0c wants to merge 1 commit into
trycompai:mainfrom
reall0c:add-pln-to-supported-currencies
Open

feat(db): add PLN to supported currencies#189
reall0c wants to merge 1 commit into
trycompai:mainfrom
reall0c:add-pln-to-supported-currencies

Conversation

@reall0c

@reall0c reall0c commented Aug 28, 2026

Copy link
Copy Markdown

Deals sold to Polish public-sector and SMB customers are invoiced in złoty, and today an amount can't be recorded in its actual currency. The keyless rate feed (open.er-api.com) already quotes PLN, so this is just the list entry plus the spec expectation.

Currency tests, check-types, lint and lint:slop pass locally; verified on a local install (a PLN deal saves cleanly).


Summary by cubic

Adds PLN to the supported currencies so deals invoiced in Polish złoty can be recorded in their actual currency. The exchange rate feed already quotes PLN, so no other changes are required.

Written for commit 5f77ccf. Summary will update on new commits.

Review in cubic

Deals sold to Polish public-sector and SMB customers are invoiced in złoty;
without PLN on the list a deal amount cannot be recorded in its actual
currency. The keyless rate feed (open.er-api.com) already quotes PLN, so no
other change is needed.
@vercel

vercel Bot commented Aug 28, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the Comp AI - PoC Team on Vercel.

A member of the Team first needs to authorize it.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/db/test/currency.spec.ts">

<violation number="1" location="packages/db/test/currency.spec.ts:77">
P3: The test name says "eleven currencies" but the expected list now has twelve. Rename it to "twelve currencies" so the description stays accurate as the supported set grows.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

"CHF",
"HKD",
"SGD",
"PLN",

@cubic-dev-ai cubic-dev-ai Bot Aug 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: The test name says "eleven currencies" but the expected list now has twelve. Rename it to "twelve currencies" so the description stays accurate as the supported set grows.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/db/test/currency.spec.ts, line 77:

<comment>The test name says "eleven currencies" but the expected list now has twelve. Rename it to "twelve currencies" so the description stays accurate as the supported set grows.</comment>

<file context>
@@ -74,6 +74,7 @@ describe("normalizeCurrency and isCurrencyCode", () => {
 			"CHF",
 			"HKD",
 			"SGD",
+			"PLN",
 			"ZAR",
 		]);
</file context>
Fix with cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant