Skip to content

feat(db): add PLN to supported currencies #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reall0c wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −0
Open

feat(db): add PLN to supported currencies #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/db/src/currency.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ const CURRENCY_LIST: readonly CurrencyMeta[] = [
{ code: "CHF", name: "Swiss Franc", minorUnits: 2 },
{ code: "HKD", name: "Hong Kong Dollar", minorUnits: 2 },
{ code: "SGD", name: "Singapore Dollar", minorUnits: 2 },
{ code: "PLN", name: "Polish Złoty", minorUnits: 2 },
{ code: "ZAR", name: "South African Rand", minorUnits: 2 },
] as const;

Expand Down
1 change: 1 addition & 0 deletions packages/db/test/currency.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ describe("normalizeCurrency and isCurrencyCode", () => {
"CHF",
"HKD",
"SGD",
"PLN",

@cubic-dev-ai cubic-dev-ai Bot Aug 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: The test name says "eleven currencies" but the expected list now has twelve. Rename it to "twelve currencies" so the description stays accurate as the supported set grows.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At packages/db/test/currency.spec.ts, line 77:

<comment>The test name says "eleven currencies" but the expected list now has twelve. Rename it to "twelve currencies" so the description stays accurate as the supported set grows.</comment>

<file context>
@@ -74,6 +74,7 @@ describe("normalizeCurrency and isCurrencyCode", () => {
 			"CHF",
 			"HKD",
 			"SGD",
+			"PLN",
 			"ZAR",
 		]);
</file context>
Fix with cubic

"ZAR",
]);
});
Expand Down