🧹 Recover unique value from closed conflicted PRs - #51
Merged
Merged
Conversation
Port the unique tests and helper extracts from closed PRs 28, 32, 34, 36-41, and 43 onto current main. Skip merge, lockfile, and as_chunks noise. - CancellationToken unit coverage - host_isolated_localhost invalid-config tests - split protocol debug redaction tests - split CDP capabilities live-ownership tests - extract CLI run helpers - extract generate_interrupted_ack - extract linux/non-linux capabilities - extract native_click and hotkey platform helpers - extract Windows screen capture module
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_a4302c71-5c75-4803-ad16-17164151f2d7) |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port the unique tests and helper extracts from closed, conflicted PRs onto current main. Merge/lockfile/as_chunks noise is left behind.
Recovered from:
runfunction in main.rs #34 CLIruncommand helpersstatusfunction insrc/lib.rs#37generate_interrupted_acknative_clickfunction by extracting platform logic #39 native_click platform helpershotkeyfunction into platform-specific helpers #40 hotkey platform helpersBehavior is unchanged.
cargo testandcargo fmt --checkpass locally.Note
Low Risk
Mechanical extractions and added/split unit tests; PR states behavior is unchanged and tests pass locally.
Overview
Ports refactors and tests from closed conflicted PRs onto main without changing runtime behavior.
Refactors: CLI match arms in
main.rsmove intorun_*helpers;NativeExecutor::capabilitiessplits intolinux_capabilities/non_linux_capabilities; ledger interruption ack building moves togenerate_interrupted_ack; platform hotkey, mouse click, and Windows screen-hash logic move towin_hotkey/mac_hotkey,native_click_*, and newwindows_capture.rs.Tests: Adds
CancellationTokenandhost_isolated_localhostinvalid-config coverage; splits CDP capability/ownership assertions into separate cases (pre-observation, post-observation, expiry, lost ownership, stale generation); splits protocolDebugredaction tests by concern (authority, request, actions).Reviewed by Cursor Bugbot for commit c4b20f7. Configure here.