add JLCPCB footprint autocomplete#671
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6413b21578
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
seveibar
left a comment
There was a problem hiding this comment.
be EXTREMELY CAREFUL- if too many strings are added all autocomplete breaks. Test autocomplete to make sure you didn't break it
|
There are no too many strings now. There are actually fewer autocomplete strings than in KiCad. |
|
Thank you for your contribution! 🎉 PR Rating: ⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
Summary
lib/generated/jlcpcb-autocomplete.tsusing the public jlcsearch APIFootprintPropjlcpcb:footprint selectors inpcbSxand update the footprint autocomplete type testWhy
JLCPCB footprint source strings were missing from the typed autocomplete surface, so consumers could not get type-safe autocomplete for
jlcpcb:footprint references.Impact
Consumers can now use
jlcpcb:C...footprint references with autocomplete and type support across footprint props and the matchingpcbSxselector path.Validation
bun scripts/generate-component-types.tsbun scripts/generate-manual-edits-docs.tsbun scripts/generate-readme-docs.tsbun scripts/generate-props-overview.tsbun scripts/generate-jlcpcb-autocomplete.tsbun testbun run typecheckbun run format:check