Skip to content

add JLCPCB footprint autocomplete#671

Merged
techmannih merged 3 commits into
mainfrom
codex/add-jlcpcb-footprint-autocomplete-refresh
May 15, 2026
Merged

add JLCPCB footprint autocomplete#671
techmannih merged 3 commits into
mainfrom
codex/add-jlcpcb-footprint-autocomplete-refresh

Conversation

@techmannih
Copy link
Copy Markdown
Member

Summary

  • add a generator for lib/generated/jlcpcb-autocomplete.ts using the public jlcsearch API
  • export the generated JLCPCB autocomplete path type and include it in FootprintProp
  • allow jlcpcb: footprint selectors in pcbSx and update the footprint autocomplete type test
  • add the package script needed to regenerate the JLCPCB autocomplete dataset
  • keep the generator output Biome-clean so the generated file passes formatting checks

Why

JLCPCB footprint source strings were missing from the typed autocomplete surface, so consumers could not get type-safe autocomplete for jlcpcb: footprint references.

Impact

Consumers can now use jlcpcb:C... footprint references with autocomplete and type support across footprint props and the matching pcbSx selector path.

Validation

  • bun scripts/generate-component-types.ts
  • bun scripts/generate-manual-edits-docs.ts
  • bun scripts/generate-readme-docs.ts
  • bun scripts/generate-props-overview.ts
  • bun scripts/generate-jlcpcb-autocomplete.ts
  • bun test
  • bun run typecheck
  • bun run format:check

@techmannih techmannih changed the title [codex] add JLCPCB footprint autocomplete add JLCPCB footprint autocomplete May 14, 2026
@techmannih techmannih marked this pull request as ready for review May 14, 2026 11:56
@techmannih techmannih requested review from seveibar and removed request for seveibar May 14, 2026 11:57
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6413b21578

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/generate-jlcpcb-autocomplete.ts
Copy link
Copy Markdown
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

be EXTREMELY CAREFUL- if too many strings are added all autocomplete breaks. Test autocomplete to make sure you didn't break it

@techmannih
Copy link
Copy Markdown
Member Author

There are no too many strings now. There are actually fewer autocomplete strings than in KiCad.

@techmannih techmannih merged commit f825db4 into main May 15, 2026
4 checks passed
@techmannih techmannih deleted the codex/add-jlcpcb-footprint-autocomplete-refresh branch May 15, 2026 04:41
@tscircuitbot
Copy link
Copy Markdown
Contributor


Thank you for your contribution! 🎉

PR Rating:
Impact: Tiny

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants