Skip to content

add JLCPCB footprint autocomplete #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
techmannih merged 3 commits into from
May 15, 2026
Merged

add JLCPCB footprint autocomplete #671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6413b21
add JLCPCB footprint autocomplete
techmannih May 14, 2026
b564aad
up
techmannih May 14, 2026
ca90d09
up
techmannih May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/common/footprintProp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import type { ReactElement } from "react"
import { z } from "zod"
import { type AutocompleteString } from "./autocomplete"
import type { KicadAutocompleteStringPath } from "../generated/kicad-autocomplete"
import type { JlcpcbAutocompleteStringPath } from "../generated/jlcpcb-autocomplete"
import type { FootprinterStringExample } from "../generated/footprinter-autocomplete"

/**
Expand Down Expand Up @@ -51,6 +52,7 @@ type FootprinterStringAutocomplete = BasicFootprint | FootprinterStringExample
export type FootprintProp =
| AutocompleteString<FootprinterStringAutocomplete>
| KicadAutocompleteStringPath
| JlcpcbAutocompleteStringPath
| ReactElement
| FootprintSoupElements[]

Expand Down
1 change: 1 addition & 0 deletions lib/common/pcbSx.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { z } from "zod"

export type PcbSxSelector =
| "& footprint[src^='kicad:'] silkscreentext"
| "& footprint[src^='jlcpcb:'] silkscreentext"
| "& silkscreentext"
| "& fabricationnotetext"

Expand Down
Loading
Loading