Rewrite COOKIES.md for App-Bound Encryption reality (SOU-155)#36
Merged
Conversation
Contributor
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
ceiling | fc8ca3c | Commit Preview URL Branch Preview URL |
Jul 16 2026, 09:29 AM |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe tray resize warning now uses the Ceiling product name. Cookie documentation covers browser source defaults, Windows automatic import behavior, manual Chromium extraction, encrypted persistence, and troubleshooting. ChangesTray panel warning
Cookie import guidance
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/COOKIES.md`:
- Line 28: Update the manual-cookie storage documentation near the ManualCookies
description to qualify guarantees by platform: state that Windows uses DPAPI
encryption and a user-only ACL, while non-Windows platforms store contents
unencrypted with restrictive 0600 file permissions. Preserve the statement that
cookies persist across restarts.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: f81fa501-dcd8-4e1a-a779-737a2d387115
📒 Files selected for processing (2)
apps/desktop-tauri/src/hooks/useTrayPanelLayout.tsdocs/COOKIES.md
tsouth89
added a commit
that referenced
this pull request
Jul 17, 2026
…OU-155) - Remove the unused TrayOpenCodexBar locale key. It carried stale CodexBar branding and was never rendered; the live tray item uses TrayPopOutDashboard (tray_menu.rs). Dropped from keys.ts, locale.rs, and all 7 .ftl locales, keeping TS<->Rust key parity. - Reword the browser-cookie empty state so it sets expectations up front: on Chrome/Edge/Brave, App-Bound Encryption usually blocks automatic import, so pasting the cookie header is the reliable path. COOKIES.md already reflects ABE reality (SOU-155 PR #36). Remaining "CodexBar" strings are intentional upstream attribution in About.
tsouth89
added a commit
that referenced
this pull request
Jul 17, 2026
Two v1-readiness cleanups. **Both change visual/user-facing surfaces that can't be pixel-verified headlessly — needs an eyeball on Windows before merge.** ## 1. Native-control theming audit (extends SOU-224) The dropdown fix (#38) removed native `<select>`. Same WebView2 root cause remained on **checkboxes**: `.provider-detail-toggle` (Claude/Codex credential toggles) and `.providers-sidebar__checkbox` (provider enable/disable) were raw native `<input type="checkbox">` with only margin set, so the OS drew them in its own theme (light checkbox inside the dark UI). - Folded both onto the existing custom `.toggle` styling: `appearance:none` + CSS checkmark + accent fill + explicit `[data-theme="light"]` overrides. Every checkbox now matches the app theme in both modes. - Audited the rest: **range sliders** (`.settings-field`, `.menu-surface__footer-zoom-slider`) and **scrollbars** already carry per-theme styling — no change needed. Number-spinner arrows are OS-drawn but minor. ## 2. SOU-155 leftovers - **Removed the dead `TrayOpenCodexBar` locale key** — stale CodexBar branding, never rendered (the live tray item uses `TrayPopOutDashboard` in `tray_menu.rs`). Dropped from `keys.ts`, `locale.rs`, and all 7 `.ftl` locales; TS↔Rust key parity preserved (`check-locale` green). - **Clarified the browser-cookie empty state**: it now states up front that App-Bound Encryption usually blocks automatic import on Chrome/Edge/Brave, so pasting the cookie header is the reliable path. - COOKIES.md already reflects ABE reality (PR #36). Remaining `CodexBar` strings are intentional upstream attribution in the About tab. ## Verification - `pnpm test` — 45 files / 226 tests pass - `pnpm run build` — check-locale + tsc + vite green - `cargo check` (shared crate) — green after the locale enum change ## Eyeball checklist (Windows, both themes) - Credential toggles (Settings → Providers → Claude/Codex) and the sidebar provider checkboxes: box + checkmark match the theme, accent fill when checked - Browser-cookie empty state reads clearly Partially addresses SOU-155; native-control audit extends SOU-224. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **User Interface** - Unified macOS-style checkbox visuals across provider and settings controls. - Enhanced interaction states (hover, focus, checked, disabled) with consistent light-theme behavior. - **Localization** - Updated the tray “pop out” dashboard label to “Open Ceiling.” - Removed an outdated tray translation entry. - **Bug Fixes** - Clarified browser cookie import empty-state guidance when automatic import is blocked for unsupported scenarios. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: tsouth89 <tsouth89@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the documentation core of SOU-155.
What was wrong
docs/COOKIES.mdclaimed Chrome/Edge cookie import is "✅ Automatic" and that cookies are held "in-memory". Runtime reality (verified inrust/src/browser/cookies.rs+rust/src/settings.rs):v20cookies) blocks automatic import for most profiles; the code surfaces a specificAppBoundEncryptionerror.ManualCookiesstore (user-only ACL), not in memory.Changes
docs/COOKIES.mdaround ABE reality, the manual/Cursor-auto defaults, Firefox's unencrypted path, and DPAPI persistence.CodexBarstring inuseTrayPanelLayout.ts's console warning.Remaining SOU-155 sub-tasks (follow-up, not in this PR)
TrayOpenCodexBarlocale key (touches the i18n key list + locale value defs).The AboutTab links to Win-CodexBar / CodexBar are intentional upstream attribution and are left as-is.
Summary by CodeRabbit
Bug Fixes
Documentation