v1 polish: checkbox theming audit + SOU-155 leftovers#39
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
ceiling | 24c3ad4 | Commit Preview URL Branch Preview URL |
Jul 17 2026, 03:45 AM |
Extends the SOU-224 dropdown fix to checkboxes. The provider-detail credential toggles (.provider-detail-toggle) and the provider-enable checkbox in the sidebar (.providers-sidebar__checkbox) were raw native <input type="checkbox"> with only margin set, so WebView2 drew them in the OS theme (a light checkbox inside the dark UI, same root cause as the dropdowns). Fold both onto the existing custom .toggle styling (appearance:none + CSS checkmark + accent fill + explicit [data-theme="light"] overrides) so every checkbox matches the app theme in both modes. Range sliders (.settings-field, .menu-surface__footer-zoom-slider) and scrollbars already carry per-theme styling; no change needed there.
…OU-155) - Remove the unused TrayOpenCodexBar locale key. It carried stale CodexBar branding and was never rendered; the live tray item uses TrayPopOutDashboard (tray_menu.rs). Dropped from keys.ts, locale.rs, and all 7 .ftl locales, keeping TS<->Rust key parity. - Reword the browser-cookie empty state so it sets expectations up front: on Chrome/Edge/Brave, App-Bound Encryption usually blocks automatic import, so pasting the cookie header is the reliable path. COOKIES.md already reflects ABE reality (SOU-155 PR #36). Remaining "CodexBar" strings are intentional upstream attribution in About.
tsouth89
force-pushed
the
tsouth2/v1-polish
branch
from
July 17, 2026 03:40
69896c6 to
b7f8fad
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe change removes the obsolete ChangesLocalization updates
Checkbox styling
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/desktop-tauri/src/styles.css`:
- Around line 659-661: Update the light-theme selector block for .toggle,
.provider-detail-toggle input[type="checkbox"], and .providers-sidebar__checkbox
so it does not override the checked-state accent background and border. Exclude
checked inputs from the generic light-theme override or add a more specific
checked rule that preserves the existing accent styling and keeps the checkmark
visible.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: ffcca6aa-9507-47a8-9a29-84bd622112f1
📒 Files selected for processing (4)
apps/desktop-tauri/src/i18n/keys.tsapps/desktop-tauri/src/styles.cssrust/src/locale.rsrust/src/locale/en-US.ftl
💤 Files with no reviewable changes (2)
- apps/desktop-tauri/src/i18n/keys.ts
- rust/src/locale.rs
The light-theme base rule for checkboxes has equal specificity to :checked and comes later, so it was overriding the accent background for checked boxes in light mode. Restate the checked accent with higher specificity (light + :checked) so it wins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two v1-readiness cleanups. Both change visual/user-facing surfaces that can't be pixel-verified headlessly — needs an eyeball on Windows before merge.
1. Native-control theming audit (extends SOU-224)
The dropdown fix (#38) removed native
<select>. Same WebView2 root cause remained on checkboxes:.provider-detail-toggle(Claude/Codex credential toggles) and.providers-sidebar__checkbox(provider enable/disable) were raw native<input type="checkbox">with only margin set, so the OS drew them in its own theme (light checkbox inside the dark UI)..togglestyling:appearance:none+ CSS checkmark + accent fill + explicit[data-theme="light"]overrides. Every checkbox now matches the app theme in both modes..settings-field,.menu-surface__footer-zoom-slider) and scrollbars already carry per-theme styling — no change needed. Number-spinner arrows are OS-drawn but minor.2. SOU-155 leftovers
TrayOpenCodexBarlocale key — stale CodexBar branding, never rendered (the live tray item usesTrayPopOutDashboardintray_menu.rs). Dropped fromkeys.ts,locale.rs, and all 7.ftllocales; TS↔Rust key parity preserved (check-localegreen).CodexBarstrings are intentional upstream attribution in the About tab.Verification
pnpm test— 45 files / 226 tests passpnpm run build— check-locale + tsc + vite greencargo check(shared crate) — green after the locale enum changeEyeball checklist (Windows, both themes)
Partially addresses SOU-155; native-control audit extends SOU-224.
Summary by CodeRabbit
User Interface
Localization
Bug Fixes