Skip to content

v1 polish: checkbox theming audit + SOU-155 leftovers #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tsouth89 merged 3 commits into from
Jul 17, 2026
Merged

v1 polish: checkbox theming audit + SOU-155 leftovers #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf28cc6
Theme checkboxes for dark/light across the app (native-control audit)
tsouth89 Jul 16, 2026
b7f8fad
Scrub dead TrayOpenCodexBar key and clarify ABE cookie empty-state (S…
tsouth89 Jul 16, 2026
24c3ad4
Keep checkbox accent fill in light theme (CodeRabbit)
tsouth89 Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion apps/desktop-tauri/src/i18n/keys.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,6 @@ export const ALL_LOCALE_KEYS = [
"TodayCost",
"Last30DaysCost",
"StatusLabel",
"TrayOpenCodexBar",
"TrayPopOutDashboard",
"TrayShowWindow",
"TrayShowTaskbarUsage",
Expand Down
37 changes: 30 additions & 7 deletions apps/desktop-tauri/src/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,7 +596,9 @@ html {
}

/* macOS-style checkbox (replaces iOS-style switch toggle) */
.toggle {
.toggle,
.provider-detail-toggle input[type="checkbox"],
.providers-sidebar__checkbox {
appearance: none;
-webkit-appearance: none;
width: 16px;
Expand All @@ -613,16 +615,22 @@ html {
transition: background 0.12s, border-color 0.12s;
}

.toggle:hover:not(:disabled) {
.toggle:hover:not(:disabled),
.provider-detail-toggle input[type="checkbox"]:hover:not(:disabled),
.providers-sidebar__checkbox:hover:not(:disabled) {
border-color: rgba(255, 255, 255, 0.45);
}

.toggle:checked {
.toggle:checked,
.provider-detail-toggle input[type="checkbox"]:checked,
.providers-sidebar__checkbox:checked {
background: var(--accent, #0a84ff);
border-color: var(--accent, #0a84ff);
}

.toggle:checked::after {
.toggle:checked::after,
.provider-detail-toggle input[type="checkbox"]:checked::after,
.providers-sidebar__checkbox:checked::after {
content: "";
position: absolute;
left: 4px;
Expand All @@ -634,21 +642,36 @@ html {
transform: rotate(45deg);
}

.toggle:focus-visible {
.toggle:focus-visible,
.provider-detail-toggle input[type="checkbox"]:focus-visible,
.providers-sidebar__checkbox:focus-visible {
outline: 2px solid var(--accent, #0a84ff);
outline-offset: 1px;
}

.toggle:disabled {
.toggle:disabled,
.provider-detail-toggle input[type="checkbox"]:disabled,
.providers-sidebar__checkbox:disabled {
opacity: 0.5;
cursor: not-allowed;
}

[data-theme="light"] .toggle {
[data-theme="light"] .toggle,
[data-theme="light"] .provider-detail-toggle input[type="checkbox"],
[data-theme="light"] .providers-sidebar__checkbox {
Comment thread
coderabbitai[bot] marked this conversation as resolved.
border-color: rgba(0, 0, 0, 0.28);
background: rgba(255, 255, 255, 0.9);
}

/* Keep the accent fill on checked boxes in light theme (the light base rule
above has equal specificity to `:checked`, so restate it with higher). */
[data-theme="light"] .toggle:checked,
[data-theme="light"] .provider-detail-toggle input[type="checkbox"]:checked,
[data-theme="light"] .providers-sidebar__checkbox:checked {
background: var(--accent, #0a84ff);
border-color: var(--accent, #0a84ff);
}

.toggle-label {
display: inline-flex;
align-items: center;
Expand Down
1 change: 0 additions & 1 deletion rust/src/locale.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,6 @@ locale_keys! {
StatusLabel,

// Tray - Single icon mode
TrayOpenCodexBar,
TrayPopOutDashboard,
TrayShowWindow,
TrayShowTaskbarUsage,
Expand Down
3 changes: 1 addition & 2 deletions rust/src/locale/en-US.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,6 @@ Tokens1K = 1K tokens
TodayCost = Today: ${ "{:.2}" }
Last30DaysCost = Last 30 days: ${ "{:.2}" }
StatusLabel = Status: { "{}" }
TrayOpenCodexBar = Pop Out Dashboard
TrayPopOutDashboard = Open Ceiling
TrayShowWindow = Show Window
TrayShowTaskbarUsage = Show Taskbar Usage
Expand Down Expand Up @@ -526,7 +525,7 @@ CredentialStatusPlaintext = Plaintext
CredentialStatusUnavailable = Unavailable
CredentialStatusUnreadable = Unreadable
BrowserCookiesSectionTitle = Browser Cookies
BrowserCookieNoneSaved = No cookie saved.
BrowserCookieNoneSaved = No cookie saved yet. On Chrome, Edge, and Brave, automatic import is usually blocked by App-Bound Encryption, so pasting the cookie header below is the most reliable setup.
BrowserCookieSavedBadge = Saved
BrowserCookieRemove = Remove
BrowserCookieImportSuccess = Cookies imported successfully.
Expand Down
Loading