Skip to content

Fix trace command cwd handling on Windows#77

Open
mysubb01 wants to merge 1 commit into
tsperf:mainfrom
mysubb01:codex/fix-trace-cross-drive
Open

Fix trace command cwd handling on Windows#77
mysubb01 wants to merge 1 commit into
tsperf:mainfrom
mysubb01:codex/fix-trace-cross-drive

Conversation

@mysubb01
Copy link
Copy Markdown

Summary

  • remove the inline cd ...; wrapper from the trace command
  • run the configured trace command with spawn using cwd instead
  • add shell quoting helpers and tests for Windows/POSIX trace directory substitution

Why

This addresses #48. On Windows, cd without /d cannot switch drives, so a project on P: launched from a storage path on C: fails before tsc --generateTrace runs. Passing the project path through spawn({ cwd }) avoids embedding a drive-changing cd in the shell command.

Verification

  • pnpm lint
  • pnpm typecheck
  • pnpm exec vitest run
  • pnpm build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants