Skip to content

ADD: CMG model command method - #86

Open
Nav2607 wants to merge 4 commits into
virtual-sensorsfrom
dev/cmg-model
Open

ADD: CMG model command method#86
Nav2607 wants to merge 4 commits into
virtual-sensorsfrom
dev/cmg-model

Conversation

@Nav2607

@Nav2607 Nav2607 commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Closes #40

  • Added command method in VirtualCMG
  • Applied clipping for max and min limits

@Nav2607
Nav2607 requested a review from wlodaralex August 11, 2026 19:01
@Nav2607 Nav2607 linked an issue Aug 11, 2026 that may be closed by this pull request
SENSORS/ACTUATORS - implement CMG model #40
Open
wlodaralex
wlodaralex requested changes Aug 18, 2026
View reviewed changes
Comment thread hardware/actuators/actuators.py Outdated
Comment thread hardware/actuators/actuators.py Outdated
Comment thread hardware/actuators/actuators.py Outdated
Comment thread hardware/actuators/actuators.py Outdated
@Nav2607

Nav2607 commented Aug 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Addressed all four review comments:

  • CMG params now load from cfg_file (generic_cmg.json) instead of
    constructor arguments
  • Removed internal gimbal_rate/gimbal_angle state from the class
  • command() now takes state as an argument and returns the updated
    [gimbal_rate, gimbal_angle] array
  • Fixed a missing comma in fss_15m.json

@Nav2607
Nav2607 requested review from wlodaralex August 29, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wlodaralex wlodaralex Awaiting requested review from wlodaralex

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SENSORS/ACTUATORS - implement CMG model

2 participants

@Nav2607 @wlodaralex