sed: implement modern diagnostic like coreutils - #576
Merged
Merged
Conversation
sylvestre
added this pull request to stack #577
September 26, 2026 17:56
sylvestre
force-pushed
the
modern-diag
branch
from
September 26, 2026 18:06
46b0c68 to
68ccda3
Compare
sylvestre
force-pushed
the
modern-diag
branch
from
September 26, 2026 18:22
68ccda3 to
7aa9e56
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #576 +/- ##
==========================================
- Coverage 83.87% 83.71% -0.17%
==========================================
Files 14 14
Lines 6977 7060 +83
Branches 407 413 +6
==========================================
+ Hits 5852 5910 +58
- Misses 1121 1145 +24
- Partials 4 5 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merging this PR will degrade performance by 3.69%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | number_fix |
1.1 s | 1.3 s | -11.02% |
| ❌ | access_log_translit |
1 s | 1 s | -3.17% |
| ⚡ | access_log_subst |
2.4 s | 2.3 s | +3.69% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing modern-diag (c099152) with main (72ed709)
sylvestre
force-pushed
the
modern-diag
branch
from
September 27, 2026 09:42
7aa9e56 to
c8b994d
Compare
sylvestre
changed the title
sylvestre
force-pushed
the
modern-diag
branch
from
September 27, 2026 15:40
c8b994d to
a1f4d55
Compare
sylvestre
force-pushed
the
modern-diag
branch
from
September 27, 2026 15:48
a1f4d55 to
30116a2
Compare
sylvestre
force-pushed
the
modern-diag
branch
from
September 27, 2026 16:50
30116a2 to
f4a7fb4
Compare
When stderr is a terminal (or UUTILS_DIAG=always), quote the offending script line and underline the faulty character, in the layout uucore's diagnostics use. Pipes and the test suite still get the single-line message. Both error constructors handle this, so no call site changes. ScriptLocation now carries the line text, captured only when diagnostics are on and shared between commands from the same line, so semantic errors raised after compilation can still be drawn. Anything that cannot be drawn (non-UTF-8 script, empty line, no line recorded) leaves the message unchanged.
sylvestre
force-pushed
the
modern-diag
branch
from
September 27, 2026 18:17
f4a7fb4 to
c099152
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.