feat: add getItemTexts to the menu testers (#242) (CP: 25.3) - #247
Merged
Merged
Conversation
The menu testers can now tell you which items a menu shows. `MenuBarTester`, `ContextMenuTester` and `GridContextMenuTester` get a `getItemTexts()` method, so a test can assert the contents of a menu instead of guessing them. Fixes #216
Contributor
Test Results1 517 tests 1 517 ✅ 41s ⏱️ Results for commit 518800a. ♻️ This comment has been updated with latest results. |
mcollovati
previously approved these changes
Sep 18, 2026
mcollovati
added a commit
that referenced
this pull request
Sep 18, 2026
…#251) The context menu test that checks which item texts a menu reports was one item short, so it failed on `main` and on the 25.3 cherry-pick (#247). The expectation now lists every item a user sees. The two changes involved never met in CI: the test fixture gained a visible "Duplicated Hidden" item in #238, while #242 was written and validated on a branch cut before that. The files merged without a textual conflict, so the mismatch only showed up after both had landed.
The item texts expectation in `ContextMenuTesterTest` was one item short, so this cherry-pick branch failed CI. The list now names every item a user sees. The mismatch comes from two changes that never met before landing: the test fixture gained a visible "Duplicated Hidden" item in #238, which is already on 25.3, while #242 was written on a branch cut before that. Cherry-pick of #251.
mcollovati
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks changes from the original PR #242 to branch 25.3.
Original PR description