ci: point the @since reconciliation at the real module source roots - #258
Merged
Merged
Conversation
The reconcile-since-tags action defaults each entry's source root to <artifactId>/src/main/java, but our module directories are named after the module (shared, junit6, spring, quarkus) rather than after the published artifact. Every source root was therefore missing, the action skipped all four modules, and the workflow finished in under a minute without producing any change to open a PR from. Spell out the source roots with the action's "<artifact>=<source-root>" syntax. A local run of the action now reconciles 39 files. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Artur-
previously approved these changes
Sep 22, 2026
Artur-
enabled auto-merge (squash)
September 22, 2026 06:04
…rce roots Picks up vaadin/github-actions#7, which aborts the run when a configured source root does not exist instead of skipping it silently, so a repeat of the misconfiguration this branch fixes fails the workflow instead of finishing green with an empty diff. Also includes vaadin/github-actions#6, which refuses to build an index with a failed release download. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Artur-
approved these changes
Sep 22, 2026
Artur-
pushed a commit
that referenced
this pull request
Sep 22, 2026
…258) (CP: 25.3) (#259) This PR cherry-picks changes from the original PR #258 to branch 25.3. --- #### Original PR description > ## Summary > The "Update @SInCE tags" workflow ran but never changed anything, because it looked for Java sources in directories that do not exist in this repo. This fixes the paths so the reconciliation actually finds our code. > > ## What changed > CI only — no product code or public API is touched, so nothing changes for users of the library. > > - The `reconcile-since-tags` action defaults each artifact's source root to `<artifactId>/src/main/java`. Our module directories are named after the module (`shared`, `junit6`, `spring`, `quarkus`), not after the published artifact, so every source root was missing and all four modules were skipped. The workflow finished green in under a minute with an empty diff and no PR. > - Source roots are now spelled out with the action's `<artifact>=<source-root>` syntax. A local run reconciles 39 files. > - Bumped the pinned action version. The new version fails the run when a configured source root does not exist, instead of skipping it quietly, so this kind of misconfiguration cannot pass unnoticed again. It also refuses to build an index from a failed release download. > - Added `.since-index` (the action's local cache directory) to `.gitignore`. Co-authored-by: totally-not-ai[bot] <290682512+totally-not-ai[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Update @SInCE tags" workflow ran but never changed anything, because it looked for Java sources in directories that do not exist in this repo. This fixes the paths so the reconciliation actually finds our code.
What changed
CI only — no product code or public API is touched, so nothing changes for users of the library.
reconcile-since-tagsaction defaults each artifact's source root to<artifactId>/src/main/java. Our module directories are named after the module (shared,junit6,spring,quarkus), not after the published artifact, so every source root was missing and all four modules were skipped. The workflow finished green in under a minute with an empty diff and no PR.<artifact>=<source-root>syntax. A local run reconciles 39 files..since-index(the action's local cache directory) to.gitignore.