Skip to content

[RSDK-13506] Round trip tool for trajectory generation#191

Merged
acmorrow merged 6 commits intoviam-modules:mainfrom
acmorrow:RSDK-13506-failed-trajectory-diagnostic-closure
Mar 13, 2026
Merged

[RSDK-13506] Round trip tool for trajectory generation#191
acmorrow merged 6 commits intoviam-modules:mainfrom
acmorrow:RSDK-13506-failed-trajectory-diagnostic-closure

Conversation

@acmorrow
Copy link
Contributor

This looks way worse than it is, but it gives us a round trip tool for trajectory generation: the planner now emits a standard format for failed trajectories, and there is a simple command line tool that can load that and replay the trajectory generation into our visualizer format. You can run like this:

ssh host-with-failure cat ..._trajex_failed_trajectory.json | ./.../viam-trajex-totg-replay | ./.../totg/scripts/visualize_trajectory.py

And get the phase plot immediately.

In large part, there was a lot of code motion here, because I'm also prepping for two things:

  1. Moving trajex to its own repo, and
  2. Removing support for the legacy generator.

We aren't quite ready for 2, because we still have some failing trajectories. This tool will let us make short work (hopefully!) of those failures.

@acmorrow acmorrow requested review from JohnN193 and npmenard March 12, 2026 21:59
Copy link
Contributor

@npmenard npmenard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

}

Json::Value root;
root["schema_version"] = 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:P

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mr. Claude - he was most insistent on the need for this.

@acmorrow acmorrow merged commit e4622ea into viam-modules:main Mar 13, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants