Add Pocket ID#170
Conversation
chore(release): promote canary to main
There was a problem hiding this comment.
@M1N0RM1N3R For all icons the desired design should scale either by width or height as other examples.
There was a problem hiding this comment.
it could just be that it's getting late and i'm getting eepy, but i don't quite get it? i am...not exactly a graphic designer 😅
may come back around to this later since i have stuff to do tomorrow
There was a problem hiding this comment.
Hi there, no worries at all.
Let me explain a bit:
- All the monochrome icons and logos are rendered in 600x600 frame.
- The inner icon should scale to height or width to the container.
The is a visual Figma reference to showcase the rendering in order to align the icons
https://www.figma.com/design/VIHlfpicLeTBD94u219cF9/Devicons?node-id=1-8639&t=4OzRrSX8fhOLBjpG-0
There was a problem hiding this comment.
so it wants to go aaaall the way to the edge...
simply replacing the header wasn't enough?
once i get back home (packed day today) i might dl inkscape and see about fixing it there.
There was a problem hiding this comment.
i just opened up the two icons in inkscape, and sure enough, the actual logo only went to 512x512, not the 600x600 canvas specified in the header i copied over. quickly resized them there, committed, pushed; ready for a look over when you've got time. 👍
2 participants
Pocket ID is the OIDC provider I use on my website (among ~10k reported instances), and I found its icon wasn't here yet, so might as well try my hand at adding it.
I sourced the SVGs from selfh.st, and tweaked them to (at least attempt to) follow the spec.
I used the base, black-and-white version for the color (lol) version, and the light theme one in
currentColor(transparency!) for the monochrome one.First-time contributor, don't be afraid to let me know if there's anything I need to fix.
Edits