-
Notifications
You must be signed in to change notification settings - Fork 208
Add Pocket ID #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
M1N0RM1N3R
wants to merge
4
commits into
vorillaz:canary
Choose a base branch
from
M1N0RM1N3R:main
base: canary
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Pocket ID #170
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| --- | ||
| name: "Pocket ID" | ||
| description: "Pocket ID is a simple OIDC provider that allows users to authenticate with their passkeys to your services." | ||
| icons: [pocket-id] | ||
| tags: [ | ||
| "authentication", | ||
| "authorization", | ||
| "security", | ||
| "identity", | ||
| "open-source", | ||
| "sso", | ||
| "access-management", | ||
| ] | ||
| website: "https://pocket-id.org/" | ||
| --- |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@M1N0RM1N3R For all icons the desired design should scale either by width or height as other examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it could just be that it's getting late and i'm getting eepy, but i don't quite get it? i am...not exactly a graphic designer 😅
may come back around to this later since i have stuff to do tomorrow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there, no worries at all.
Let me explain a bit:
The is a visual Figma reference to showcase the rendering in order to align the icons
https://www.figma.com/design/VIHlfpicLeTBD94u219cF9/Devicons?node-id=1-8639&t=4OzRrSX8fhOLBjpG-0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so it wants to go aaaall the way to the edge...
simply replacing the header wasn't enough?
once i get back home (packed day today) i might dl inkscape and see about fixing it there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i just opened up the two icons in inkscape, and sure enough, the actual logo only went to 512x512, not the 600x600 canvas specified in the header i copied over. quickly resized them there, committed, pushed; ready for a look over when you've got time. 👍