Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

Add view port to runner for supporting mobile device.#32

Open
xiuqijix wants to merge 3 commits into
w3c:masterfrom
xiuqijix:xiuqi/viewport
Open

Add view port to runner for supporting mobile device.#32
xiuqijix wants to merge 3 commits into
w3c:masterfrom
xiuqijix:xiuqi/viewport

Conversation

@xiuqijix

@xiuqijix xiuqijix commented Sep 2, 2015

Copy link
Copy Markdown

This change is Reviewable

@hoppipolla-critic-bot

Copy link
Copy Markdown

Critic review: https://critic.hoppipolla.co.uk/r/5774

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@xiuqijix xiuqijix changed the title Xiuqi/viewport Add view port to runner for supporting mobile device. Sep 9, 2015
@jgraham

jgraham commented Nov 30, 2015

Copy link
Copy Markdown
Member

What's the status here? I think it would be OK to merge only the <meta name=viewport> part of the patch.

@yugang

yugang commented Dec 2, 2015

Copy link
Copy Markdown

@jgraham , the first two commits have the same reason here: #31, we just need merge the last one of the three commits.

@xiuqijix

xiuqijix commented Dec 8, 2015

Copy link
Copy Markdown
Author

@jgraham , the first two commits have the same reason here: #31 .You can merge #32 after #31 , thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants