Skip to content

Add rule requiring confirmation before adding muffet exclusions #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mithro merged 1 commit into from
Jun 8, 2026
+14 −0
Merged

Add rule requiring confirmation before adding muffet exclusions #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,3 +129,17 @@ Make sure you are on the right branch before doing any work.
- Once the pull request has been created, wait for the GitHub Action checks to run and fix any issues they find.
- Wait for GitHub Copilot to review your pull request and then use the GitHub GraphQL API to find all code suggestions, fix the issues and then resolve the threads.

## Preview Verification

Pull requests are checked by the `preview-verification.yml` workflow, which runs the [muffet](https://github.com/raviqqe/muffet) link checker against the per-PR preview site.

### NEVER Add Muffet Exclusions Without Confirmation

**NEVER add exclusions to `.github/workflows/preview-verification.yml` without first asking the user for confirmation using the AskUserQuestion tool.** Exclusions hide potential problems and should be deliberate decisions, not automatic fixes.

Before proposing an exclusion, you MUST:
1. Investigate the root cause of the failure
2. Attempt to fix the actual problem (broken URL, missing anchor, etc.)
3. If an exclusion is truly needed, use AskUserQuestion to explain the situation and get explicit approval
4. Document why the exclusion is necessary in the commit message

Loading