feat(loader): centralize source-aware parallel admission - #674
Merged
Kaden-Schutt merged 11 commits intoSep 1, 2026
Conversation
added 6 commits
September 1, 2026 13:48
This was referenced Sep 1, 2026
Trades 409 daemon lines for a prepare/commit transaction that retains and revalidates canonical artifact identity instead of reopening mutable paths after admission.
RATCHET-RAISE: daemon_lines 4155 -> 4564, traded for source-aware admission and opaque loader-owned handles while preserving Rust-only control-plane ownership.
Kaden-Schutt
force-pushed
the
feat/device-mesh-g2-admission
branch
from
September 1, 2026 22:24
b5d014c to
022547d
Compare
# Conflicts: # crates/hipfire-arch-deepseek4/map.md # crates/hipfire-arch-qwen35/map.md # crates/hipfire-daemon/map.md # crates/hipfire-loader/map.md # crates/hipfire-loader/src/lib.rs # crates/hipfire-runtime/map.md
Kaden-Schutt
marked this pull request as ready for review
September 1, 2026 22:38
Kaden-Schutt
approved these changes
Sep 1, 2026
Collaborator
|
Note for anyone landing here: this PR shows MERGED, but its content was backed out of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #674 implements the G2 source-aware parallel-admission boundary. It opens a model source once, classifies its source namespace and model variant, resolves the raw PP/TP/EP request through one typed policy matrix, and returns the effective G1
DeviceMeshtogether with the retained carrier/source—or a typed refusal. Admission now completes before prior-model teardown, VMM/GPU initialization, remapping, carrier entry, or other model-owner side effects.This is the G2 admission changeset tracked by #666.
What changed
crates/hipfire-loader/src/parallel_capability.rs, which definesSourceKind,ModelVariant,ParallelAxis,RawParallelism, the source-awareCellPolicymatrix, and typedAdmissionErrordiagnostics. Degree-zero requests and forbidden PP/TP/EP compositions are rejected first; compatibility remapping and normalization cannot hide malformed requests.tpdenotes EP, keeps the legacy DeepSeek4/MiniMax TP-to-EP compatibility mapping, normalizes only policy-approved dense EP requests toSingle, and enforces current executable bounds/refusals (HFQ Qwen3.5 dense TP degrees2..=5; HFQ Qwen3.5 MoE EP degree4; unsupported source/variant/axis cells remain hard refusals).AdmittedLoadto carry the already-openModelSource, selected carrier, source/variant facts, and effective mesh through the daemon'sDaemonLoadStateteardown into execution. Regular, Gemma4, EP, and dense-TP loader entrypoints now consume this value; EP rank loaders reuse the retained HFQ instead of reopening and reclassifying the path.crates/hipfire-loader,crates/hipfire-daemon, andcrates/hipfire-arch-qwen35; the change is an admission/routing cutover, not a new architecture implementation.Goals
Short term
Establish one immediate, centralized admission decision for every current PP/TP/EP load surface. Resolve source, model shape, and parallel policy before destructive or allocating work, then require downstream loaders and daemon backends to use the effective mesh and retained route rather than interpreting raw degrees again.
Long term
Provide the single policy authority that future multi-device load and collective paths can consume. Later G3/G5 integration should receive the admitted topology as data and extend the matrix only when a real executable route exists, rather than introducing another raw-degree capability ladder or bypass around source-aware admission.
Benefits
Dependency and landing order
mastercomparison includes feat(hardware): establish named device mesh ownership #673 until G1 merges.master; mark it ready only after that cutover.#673 → #675 → #677; feat(loader): centralize source-aware parallel admission #674 is its semantic admission prerequisite before the complete production multi-device route is enabled. G5 must consume the admitted topology so raw topology requests cannot bypass source-aware admission.Verification
cargo buildpasses on the normalized stack.cargo clippy -p hipfire-loader --all-targets --no-depscompletes; the package/workspace has pre-existing warnings.cargo testpasses: 3,474 passed, 12 ignored.python3 -m tools.change_gate run --base betawas not run.Architecture-trait change?
No
Architecturetrait surface change.Nonclaims / follow-up