feat(runtime): add device-mesh weight manifest and store pilot - #675
Closed
fivetide wants to merge 20 commits into
Closed
feat(runtime): add device-mesh weight manifest and store pilot#675fivetide wants to merge 20 commits into
fivetide wants to merge 20 commits into
Conversation
added 10 commits
September 1, 2026 13:48
This was referenced Sep 1, 2026
Propagate G1 mesh errors through layout and placement planning, preserve retryable teardown ownership in the daemon slot, and refresh generated crate maps. The daemon grows by 39 lines for typed retry restoration and rollback ownership; the ratchet records that explicit lifecycle trade.
RATCHET-RAISE: daemon_lines 4155 -> 4194, traded for typed retry restoration and rollback ownership in transactional manifest loading.
# Conflicts: # crates/hipfire-arch-llama/map.md # crates/hipfire-arch-llama/src/carrier.rs # crates/hipfire-daemon/map.md # crates/hipfire-loader/map.md # crates/hipfire-loader/src/lib.rs # crates/hipfire-runtime/map.md # crates/hipfire-runtime/src/model_load.rs
RATCHET-RAISE: daemon_lines 4564 -> 4589, traded for retryable unload restoration across the admitted-load transaction.
Collaborator
Author
|
Closing as historical provenance per this PR's own status note ("Do not close until a replacement G3 PR is published"). The replacement is published: #704 (draft, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status — historical draft; do not merge as-is
Head
f70f343166443e64f1ca44e996b892be95c1f569and the checks recorded below were produced against the displaced merged-stack base541b33c33e235efadeec67aac1da766c085cc67f, not currentmaster. #668, #673, #674, and #676 merged on 2026-09-01 and were then backed out bya0fca0d6d; currentmasteris344e17a2edd893d6e323bd69189844e95bd73a9e. This branch is dirty/non-rebaseable and consumes types absent from the current tree.This head is superseded by the G3 consistent-deliverable contract in #666. The replacement is one current-master production Single manifest/load transaction covering planning, all model-owned staged resources, typed publication, per-position parity, fault recovery, generation, existing-reset smoke, unload, and immediate retry. PR size is not the acceptance mechanism; the final composed G3 head must pass the complete matrix.
Keep this PR open and draft as historical design provenance. Do not merge, push, or rebase this head. Do not close until a replacement G3 PR is published.
Summary
Implement the G3 manifest/store layer and wire the plain LLaMA Single HFQ path to it. The branch adds pure declarations and planning for model weights, state, placements, and collectives, then fulfills that plan transactionally and publishes typed LLaMA weights under one teardown owner.
Tracks the G3 manifest/store slice in #666; it does not close G3 or claim current-tree acceptance.
What changed
hipfire-runtime::weight_manifest, a GPU- and source-format-free declaration layer.WeightEntry/StateEntrydescribe logical tensors and state; shard policies cover replication, tensor/vocabulary/head/expert placement, fused projections, ties, and mesh pins.plan_manifestresolves those declarations against an admittedDeviceMeshinto device placements, state residency, pipeline boundary hints, and an ordered collective schedule.(layer, kind): distinct row-sharded operations such aswoandffn_downremain distinct scheduled reductions. Manifest validation checks identities, shapes, shard divisibility, tied-source compatibility, and layer/state scope before fulfillment.ExpertGroupSpec,ExpertSourceLayout,ExpertParallelism, and resource requirements). Validation binds router/execution identities and packed/per-expert source names, shapes, and policies; rank ownership and executor sealing remain for the direct G5 consumer.hipfire-runtime::weight_store, keyed by(name, layer, device), with immutable projection metadata, resident or symbolic-alias handles, and aWeightOrigincontaining mesh epoch, logical rank, and physical device identity.fulfill_manifest_singleaccepts an architecture-owned source callback returning bytes plus actual source dtype, validates the target and source contract, uploads residents, materializes ties, and explicitly rolls back every earlier resident on source, dtype, payload, upload, or injected-fault failure.ArchModel::free_gpupath.lm_headtying. The HFQ carrier now admits and classifies the source before upload, sends plain non-AWQ HFQ through planning, transactional fulfillment, and typed assembly, recognizes the supported alternate explicit LM-head names, and retains AWQ-sidecar HFQ on the legacy loader. Safetensors-directory loading remains on its existing ParoQuant path while capturing the pure plan.Architecturetrait surface is unchanged.Goals
Short term
Long term
Benefits
Dependency and landing order
master; both were reverted.DeviceMeshtopology insidehipfire_runtime::multi_gpu. Do not add the revertedhipfire-hardwarecrate or combine this withGpusconstructor/all-reduce signature changes.scripts/leanup-thresholds.txttodaemon_lines <= 4589; replacement G3 work must satisfy the current<= 4155ratchet rather than raising it.Verification
Historical archived-head evidence only; none of these results establishes current-master acceptance:
f70f343166443e64f1ca44e996b892be95c1f569.cargo buildpassed on the displaced normalized stack.hipfire-runtimeandhipfire-arch-llamacompleted with existing warnings.cargo testpassed: 3,490 passed, 12 ignored.hipfire run qwen3.6:27band one A3B, with decoded text inspected and recorded.python3 -m tools.change_gate run --base betawas not run; fork tracker output is not upstream acceptance evidence.Nonclaims / follow-up
Architecturetrait surface change.Wall time: 0.69 seconds
No current-master compatibility, physical-device acceptance, production non-Single route, or completion claim is made by this historical head.