Cleanup: Disable Invert options in Light Mode#112
Draft
JacksonZ03 wants to merge 1 commit intowaymondrang:mainfrom
Draft
Cleanup: Disable Invert options in Light Mode#112JacksonZ03 wants to merge 1 commit intowaymondrang:mainfrom
JacksonZ03 wants to merge 1 commit intowaymondrang:mainfrom
Conversation
Contributor
Author
Owner
|
Hello @JacksonZ03, just wanted to poke this and let you know that #111 has been merged. Let me know if you're still interested in working on this! |
Contributor
Author
|
ah, yes. I want to keep this in drafts for now, I'm in a busy period right now, but when I have more time, I'll resume progress on this. Of course, if you want to implement this idea, you don't have to wait on me. But if not, don't worry about merge conflicts for this one, when I come back, I'll resolve them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup
Light mode currently is cluttered and there are some really unnecessary bits that both clutter the UI and the codebase itself.
First of all, the whole point of this chrome extension is to add dark mode - which naturally assumes that Google Docs is already in "Light mode".
This makes the Light Mode setting entirely redundant (apart from perhaps slight UI shading customisations that the user can change).
But besides that point, with the current lightmode, it has the invert options which invert black text to white - completely useless when text is naturally black in Light mode anyways.
And secondly, there is also an invert option that is completely useless since all it does in lightmode is invert the colored text - why a user would want to deliberately mess up their own document's colors?
So in this commit, I hide the Invert options entirely in Light mode and also remove the invert option in the advanced settings. This keeps the existing behaviour in the UI and cuts down the unnecessary bloat in the codebase.