Skip to content

Cleanup: Disable Invert options in Light Mode #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
JacksonZ03 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Cleanup: Disable Invert options in Light Mode #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions src/popup.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ <h3 class="sectionTitle hoverTip">
</div>
</div>

<div class="section">
<div id="documentInvertSection" class="section">
<h3 class="sectionTitle">Invert</h3>

<div class="sectionContent">
Expand Down Expand Up @@ -281,20 +281,6 @@ <h3 class="sectionTitle">Toggle Button</h3>
</div>
</div>
</div>

<div class="section">
<h3 class="sectionTitle">Invert</h3>
<div class="sectionContent">
<div
id="advancedInvertOptions"
class="buttonRow fullWidth"
>
<button id="documentInvertNormal">
<span>Normal</span>
</button>
</div>
</div>
</div>
</div>
</div>
</div>
Expand Down
28 changes: 14 additions & 14 deletions src/popup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,6 +464,10 @@ class TipComponent {
}

class InvertComponent extends StateSubscriber {
private section = document.querySelector(
"#documentInvertSection"
) as HTMLDivElement;

private grayButton = document.querySelector(
"#documentInvertGray"
) as HTMLButtonElement;
Expand All @@ -474,11 +478,6 @@ class InvertComponent extends StateSubscriber {
"#documentInvertOff"
) as HTMLButtonElement;

// In advanced settings category
private normalButton = document.querySelector(
"#documentInvertNormal"
) as HTMLButtonElement;

initialize(): void {
this.offButton.addEventListener("click", () => {
this.state.setData({
Expand All @@ -499,16 +498,18 @@ class InvertComponent extends StateSubscriber {
invert_enabled: true,
});
});

this.normalButton.addEventListener("click", () => {
this.state.setData({
invert_mode: InvertMode.Normal,
invert_enabled: true,
});
});
}

update(newData: ExtensionData): void {
const isDarkMode = newData.mode === ExtensionMode.Dark;

// Show invert options only in dark mode
if (isDarkMode) {
this.section.classList.remove("hidden");
} else {
this.section.classList.add("hidden");
}

this.resetAppearance();

if (!newData.invert_enabled) {
Expand All @@ -524,7 +525,7 @@ class InvertComponent extends StateSubscriber {
this.blackButton.classList.add("selected");
break;
case InvertMode.Normal:
this.normalButton.classList.add("selected");
this.offButton.classList.add("selected");
break;
default:
break;
Expand All @@ -534,7 +535,6 @@ class InvertComponent extends StateSubscriber {
resetAppearance(): void {
this.grayButton.classList.remove("selected");
this.blackButton.classList.remove("selected");
this.normalButton.classList.remove("selected");
this.offButton.classList.remove("selected");
}
}
Expand Down