Conversation
tsu-wtag
approved these changes
Aug 25, 2026
tak-wtag
approved these changes
Aug 25, 2026
mal-wtag
reviewed
Aug 25, 2026
| - https://raw.githubusercontent.com/welldev-group/default-configs/master/rubocop-default-config-ruby3.2.yml | ||
|
|
||
| inherit_gem: | ||
| rubocop-rails-omakase: rubocop.yml |
There was a problem hiding this comment.
This changes the lint ruleset for the action's own source (pronto-rubocop reads the target repo's .rubocop.yml at runtime, so this doesn't affect consumer repos like wellday). Is the switch to rubocop-rails-omakase intentional here, or did it come along for the ride while chasing the rubocop version bump? If intentional, worth a line in the PR description so it doesn't read as unrelated scope creep.
mal-wtag
reviewed
Aug 25, 2026
| gem 'pronto-scss', require: false | ||
|
|
||
| gem 'rubocop', '~> 1.50', require: false | ||
| gem "rubocop-rails-omakase", require: false |
There was a problem hiding this comment.
Now sure how we use comment in pronto but I would have added a comment in the PR description calling out that this is the actual bug fix, since the rest of the diff (Dockerfile, .rubocop.yml) reads as supporting changes around it.
mal-wtag
approved these changes
Aug 25, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OPS-4631