Skip to content

OPS-4631-rubo-cop-in-pronto-action-image-to-support-ruby-3-4 #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arh-wtag wants to merge 3 commits into
base: master
Choose a base branch
from
Open

OPS-4631-rubo-cop-in-pronto-action-image-to-support-ruby-3-4 #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d00e672
update ruby and re-install gemfile
arh-wtag Aug 25, 2026
c6ad571
Update .rubocop.yml
arh-wtag Aug 25, 2026
74dea45
fixing pronto
arh-wtag Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
inherit_from:
- https://raw.githubusercontent.com/welldev-group/default-configs/master/rubocop-default-config-ruby3.2.yml

inherit_gem:
rubocop-rails-omakase: rubocop.yml

@mal-wtag mal-wtag Aug 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the lint ruleset for the action's own source (pronto-rubocop reads the target repo's .rubocop.yml at runtime, so this doesn't affect consumer repos like wellday). Is the switch to rubocop-rails-omakase intentional here, or did it come along for the ride while chasing the rubocop version bump? If intentional, worth a line in the PR description so it doesn't read as unrelated scope creep.

2 changes: 1 addition & 1 deletion .ruby-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.2.2
3.4.10
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM ruby:3.2-alpine
FROM ruby:3.4-alpine

# Runtime dependencies
RUN apk --no-cache add \
Expand Down
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ gem 'pronto-rails_schema', require: false
gem 'pronto-reek', require: false
gem 'pronto-scss', require: false

gem 'rubocop', '~> 1.50', require: false
gem "rubocop-rails-omakase", require: false

@mal-wtag mal-wtag Aug 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now sure how we use comment in pronto but I would have added a comment in the PR description calling out that this is the actual bug fix, since the rest of the diff (Dockerfile, .rubocop.yml) reads as supporting changes around it.

232 changes: 158 additions & 74 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,76 +1,129 @@
GEM
remote: https://rubygems.org/
specs:
activesupport (7.1.2)
activesupport (8.1.3.1)
base64
bigdecimal
concurrent-ruby (~> 1.0, >= 1.0.2)
concurrent-ruby (~> 1.0, >= 1.3.1)
connection_pool (>= 2.2.5)
drb
i18n (>= 1.6, < 2)
json
logger (>= 1.4.2)
minitest (>= 5.1)
mutex_m
tzinfo (~> 2.0)
addressable (2.8.6)
public_suffix (>= 2.0.2, < 6.0)
ast (2.4.2)
base64 (0.2.0)
bigdecimal (3.1.4)
brakeman (6.1.0)
securerandom (>= 0.3)
tzinfo (~> 2.0, >= 2.0.5)
uri (>= 0.13.1)
addressable (2.9.0)
public_suffix (>= 2.0.2, < 8.0)
ast (2.4.3)
base64 (0.3.0)
bigdecimal (4.1.2)
brakeman (8.0.6)
racc
code_analyzer (0.5.5)
sexp_processor
concurrent-ruby (1.2.2)
connection_pool (2.4.1)
drb (2.2.0)
ruby2_keywords
erubi (1.12.0)
concurrent-ruby (1.3.8)
connection_pool (3.0.2)
csv (3.3.6)
drb (2.2.3)
dry-configurable (1.4.0)
dry-core (~> 1.0)
zeitwerk (~> 2.6)
dry-core (1.2.0)
concurrent-ruby (~> 1.0)
logger
zeitwerk (~> 2.6)
dry-inflector (1.3.1)
dry-initializer (3.2.0)
dry-logic (1.6.0)
bigdecimal
concurrent-ruby (~> 1.0)
dry-core (~> 1.1)
zeitwerk (~> 2.6)
dry-schema (1.16.0)
concurrent-ruby (~> 1.0)
dry-configurable (~> 1.0, >= 1.0.1)
dry-core (~> 1.1)
dry-initializer (~> 3.2)
dry-logic (~> 1.6)
dry-types (~> 1.9, >= 1.9.1)
zeitwerk (~> 2.6)
dry-types (1.9.1)
bigdecimal (>= 3.0)
concurrent-ruby (~> 1.0)
dry-core (~> 1.0)
dry-inflector (~> 1.0)
dry-logic (~> 1.4)
zeitwerk (~> 2.6)
erubi (1.13.1)
erubis (2.7.0)
faraday (2.7.12)
base64
faraday-net_http (>= 2.0, < 3.1)
ruby2_keywords (>= 0.0.4)
faraday-net_http (3.0.2)
ffi (1.16.3)
flay (2.13.1)
faraday (2.14.3)
faraday-net_http (>= 2.0, < 3.5)
json
logger
faraday-net_http (3.4.4)
net-http (~> 0.5)
ffi (1.17.4)
ffi (1.17.4-aarch64-linux-gnu)
ffi (1.17.4-aarch64-linux-musl)
ffi (1.17.4-arm-linux-gnu)
ffi (1.17.4-arm-linux-musl)
ffi (1.17.4-arm64-darwin)
ffi (1.17.4-x86-linux-gnu)
ffi (1.17.4-x86-linux-musl)
ffi (1.17.4-x86_64-darwin)
ffi (1.17.4-x86_64-linux-gnu)
ffi (1.17.4-x86_64-linux-musl)
flay (2.14.4)
erubi (~> 1.10)
path_expander (~> 1.0)
ruby_parser (~> 3.0)
path_expander (~> 2.0)
prism (~> 1.7)
sexp_processor (~> 4.0)
gitlab (4.19.0)
gitlab (4.20.1)
httparty (~> 0.20)
terminal-table (>= 1.5.1)
httparty (0.21.0)
httparty (0.24.2)
csv
mini_mime (>= 1.0.0)
multi_xml (>= 0.5.2)
i18n (1.14.1)
i18n (1.15.2)
concurrent-ruby (~> 1.0)
json (2.7.1)
kwalify (0.7.2)
language_server-protocol (3.17.0.3)
json (2.21.2)
language_server-protocol (3.17.0.6)
lint_roller (1.1.0)
logger (1.7.0)
mini_mime (1.1.5)
minitest (5.20.0)
multi_xml (0.6.0)
mutex_m (0.2.0)
octokit (7.2.0)
minitest (6.0.6)
drb (~> 2.0)
prism (~> 1.5)
multi_xml (0.9.1)
bigdecimal (>= 3.1, < 5)
net-http (0.9.1)
uri (>= 0.11.1)
octokit (10.0.0)
faraday (>= 1, < 3)
sawyer (~> 0.9)
parallel (1.23.0)
parser (3.2.2.4)
ostruct (0.6.3)
parallel (2.1.0)
parser (3.3.12.0)
ast (~> 2.4.1)
racc
path_expander (1.1.1)
pronto (0.11.2)
path_expander (2.0.1)
prism (1.9.0)
pronto (0.11.5)
gitlab (>= 4.4.0, < 5.0)
httparty (>= 0.13.7, < 1.0)
octokit (>= 4.7.0, < 8.0)
octokit (>= 4.7.0, < 11.0)
ostruct
rainbow (>= 2.2, < 4.0)
rexml (>= 3.2.5, < 4.0)
rugged (>= 0.23.0, < 2.0)
thor (>= 0.20.3, < 2.0)
pronto-brakeman (0.11.2)
brakeman (>= 3.2.0)
pronto (~> 0.11.0)
pronto-flay (0.11.1)
pronto-flay (0.11.2)
flay (~> 2.8)
pronto (~> 0.11.0)
pronto-rails_best_practices (0.11.0)
Expand All @@ -81,71 +134,102 @@ GEM
pronto-reek (0.11.1)
pronto (~> 0.11.0)
reek (>= 4.2, < 7.0)
pronto-rubocop (0.11.5)
pronto-rubocop (0.11.6)
pronto (~> 0.11.0)
rubocop (>= 0.63.1, < 2.0)
pronto-scss (0.11.0)
pronto (~> 0.11.0)
scss_lint (~> 0.43, >= 0.43.0)
public_suffix (5.0.4)
racc (1.7.3)
rails_best_practices (1.23.2)
public_suffix (7.0.5)
racc (1.8.1)
rack (3.2.7)
rails_best_practices (1.23.4)
activesupport
code_analyzer (~> 0.5.5)
erubis
i18n
json
ostruct
require_all (~> 3.0)
ruby-progressbar
rainbow (3.1.1)
rb-fsevent (0.11.2)
rb-inotify (0.10.1)
rb-inotify (0.11.1)
ffi (~> 1.0)
reek (6.1.4)
kwalify (~> 0.7.0)
parser (~> 3.2.0)
reek (6.5.0)
dry-schema (~> 1.13)
logger (~> 1.6)
parser (~> 3.3.0)
rainbow (>= 2.0, < 4.0)
regexp_parser (2.8.3)
rexml (~> 3.1)
regexp_parser (2.12.0)
require_all (3.0.0)
rexml (3.2.6)
rubocop (1.59.0)
json (~> 2.3)
language_server-protocol (>= 3.17.0)
parallel (~> 1.10)
parser (>= 3.2.2.4)
rexml (3.4.4)
rubocop (1.90.0)
json (>= 2.3)
language_server-protocol (~> 3.17.0.2)
lint_roller (~> 1.1.0)
parallel (>= 1.10)
parser (>= 3.3.0.2)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 1.8, < 3.0)
rexml (>= 3.2.5, < 4.0)
rubocop-ast (>= 1.30.0, < 2.0)
regexp_parser (>= 2.9.3, < 3.0)
rubocop-ast (>= 1.49.0, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 2.4.0, < 3.0)
rubocop-ast (1.30.0)
parser (>= 3.2.1.0)
unicode-display_width (>= 2.4.0, < 4.0)
rubocop-ast (1.50.0)
parser (>= 3.3.7.2)
prism (~> 1.7)
rubocop-performance (1.27.0)
lint_roller (~> 1.1)
rubocop (>= 1.89.0, < 2.0)
rubocop-ast (>= 1.47.1, < 2.0)
rubocop-rails (2.37.0)
activesupport (>= 4.2.0)
lint_roller (~> 1.1)
rack (>= 1.1)
rubocop (>= 1.89.0, < 2.0)
rubocop-ast (>= 1.44.0, < 2.0)
rubocop-rails-omakase (1.1.0)
rubocop (>= 1.72)
rubocop-performance (>= 1.24)
rubocop-rails (>= 2.30)
ruby-progressbar (1.13.0)
ruby2_keywords (0.0.5)
ruby_parser (3.20.3)
sexp_processor (~> 4.16)
rugged (1.7.1)
rugged (1.9.6)
sass (3.7.4)
sass-listen (~> 4.0.0)
sass-listen (4.0.0)
rb-fsevent (~> 0.9, >= 0.9.4)
rb-inotify (~> 0.9, >= 0.9.7)
sawyer (0.9.2)
sawyer (0.9.3)
addressable (>= 2.3.5)
faraday (>= 0.17.3, < 3)
scss_lint (0.60.0)
sass (~> 3.5, >= 3.5.5)
sexp_processor (4.17.0)
terminal-table (3.0.2)
unicode-display_width (>= 1.1.1, < 3)
thor (1.3.0)
securerandom (0.4.1)
sexp_processor (4.17.5)
terminal-table (4.0.0)
unicode-display_width (>= 1.1.1, < 4)
thor (1.5.0)
tzinfo (2.0.6)
concurrent-ruby (~> 1.0)
unicode-display_width (2.5.0)
unicode-display_width (3.2.0)
unicode-emoji (~> 4.1)
unicode-emoji (4.2.0)
uri (1.1.1)
zeitwerk (2.8.3)

PLATFORMS
aarch64-linux
aarch64-linux-gnu
aarch64-linux-musl
arm-linux-gnu
arm-linux-musl
arm64-darwin
ruby
x86-linux-gnu
x86-linux-musl
x86_64-darwin
x86_64-linux-gnu
x86_64-linux-musl

DEPENDENCIES
pronto
Expand All @@ -156,7 +240,7 @@ DEPENDENCIES
pronto-reek
pronto-rubocop
pronto-scss
rubocop (~> 1.50)
rubocop-rails-omakase

BUNDLED WITH
2.4.22
2.6.9
2 changes: 1 addition & 1 deletion action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ inputs:
required: true
runs:
using: 'docker'
image: 'docker://welltravel/pronto-action:latest'
image: 'docker://welltravel/pronto-action:v14_ruby_3.4.10'
args:
- ${{ inputs.github_token }}